Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1899583002: Revert of Remove shell::Loader (Closed)

Created:
4 years, 8 months ago by rkc
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove shell::Loader (patchset #3 id:40001 of https://codereview.chromium.org/1898433002/ ) Reason for revert: It looks like this CL breaks the Windows bot (https://build.chromium.org/p/chromium/buildstatus?builder=Win&number=42453). Before this CL, mojo_shell_unittests.exe weren't being built, since the target had no source files. This CL starts to build them, which exposes the link error on Windows. Tentatively reverting. Original issue's description: > Remove shell::Loader > > BUG=601884 > R=ben@chromium.org > > Committed: https://crrev.com/1de6dacd4e9c59274f2c061accfe3770f696c09b > Cr-Commit-Position: refs/heads/master@{#387800} TBR=ben@chromium.org,rockot@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=601884 Committed: https://crrev.com/9dee79720763b041a6ee7aa399384bdb64bad291 Cr-Commit-Position: refs/heads/master@{#387815}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+710 lines, -29 lines) Patch
M services/shell/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M services/shell/background/background_shell.cc View 5 chunks +47 lines, -12 lines 0 comments Download
A services/shell/loader.h View 1 chunk +26 lines, -0 lines 0 comments Download
M services/shell/shell.h View 4 chunks +26 lines, -1 line 0 comments Download
M services/shell/shell.cc View 4 chunks +41 lines, -10 lines 0 comments Download
M services/shell/shell.gyp View 2 chunks +2 lines, -1 line 0 comments Download
M services/shell/tests/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
A services/shell/tests/loader_unittest.cc View 1 chunk +560 lines, -0 lines 0 comments Download
D services/shell/tests/placeholder_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rkc
Created Revert of Remove shell::Loader
4 years, 8 months ago (2016-04-16 22:44:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899583002/1
4 years, 8 months ago (2016-04-16 22:44:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-16 22:45:23 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-16 22:47:09 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9dee79720763b041a6ee7aa399384bdb64bad291
Cr-Commit-Position: refs/heads/master@{#387815}

Powered by Google App Engine
This is Rietveld 408576698