Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: components/offline_pages/offline_page_feature.h

Issue 1899433002: Update flags used by offline pages and bookmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/offline_pages/BUILD.gn ('k') | components/offline_pages/offline_page_feature.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/offline_pages/offline_page_feature.h
diff --git a/components/offline_pages/offline_page_feature.h b/components/offline_pages/offline_page_feature.h
index fde3a5ee78eaaa8610a3eefb019901018114a513..96fd5a1dbc581963d2d5ace4ee753d0b32e5657e 100644
--- a/components/offline_pages/offline_page_feature.h
+++ b/components/offline_pages/offline_page_feature.h
@@ -10,25 +10,17 @@
namespace offline_pages {
+extern const base::Feature kOfflineBookmarksFeature;
extern const base::Feature kOffliningRecentPagesFeature;
extern const base::Feature kOfflinePagesBackgroundLoadingFeature;
-// GENERATED_JAVA_ENUM_PACKAGE: org.chromium.components.offlinepages
-enum class FeatureMode {
- // Offline pages feature is disabled.
- DISABLED,
- // Offline pages feature is enabled, showing bookmarks in UI strings.
- ENABLED_AS_BOOKMARKS,
- // Offline pages feature is enabled, showing saved pages in UI strings.
- ENABLED_AS_SAVED_PAGES
-};
-
-// Returns the mode where Offline Pages feature is running.
-FeatureMode GetOfflinePageFeatureMode();
-
-// Returns true if offline pages is enabled.
+// Returns true if offline pages, as result of one or more offline features
+// being enabled, is enabled.
bool IsOfflinePagesEnabled();
+// Returns true if saving bookmarked pages for offline viewing is enabled.
+bool IsOfflineBookmarksEnabled();
+
// Returns true if offlining of recent pages (aka 'Last N pages') is enabled.
bool IsOffliningRecentPagesEnabled();
« no previous file with comments | « components/offline_pages/BUILD.gn ('k') | components/offline_pages/offline_page_feature.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698