Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Unified Diff: components/error_page/common/localized_error.cc

Issue 1899433002: Update flags used by offline pages and bookmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome.gyp ('k') | components/error_page_strings.grdp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/error_page/common/localized_error.cc
diff --git a/components/error_page/common/localized_error.cc b/components/error_page/common/localized_error.cc
index 7285d969c5bea00ee143fe960cf82e5a37484a9d..2b5927f282237df97cb2bc6c43c3614f77ba3cff 100644
--- a/components/error_page/common/localized_error.cc
+++ b/components/error_page/common/localized_error.cc
@@ -1056,22 +1056,6 @@ void LocalizedError::GetStrings(int error_code,
error_strings->Set("showSavedCopyButton", show_saved_copy_button);
}
-#if defined(OS_ANDROID)
- // Offline button will not be provided when we want to show something in the
- // cache.
- if (!show_saved_copy_visible && has_offline_pages) {
- base::DictionaryValue* show_offline_pages_button =
- new base::DictionaryValue;
- base::string16 button_text = l10n_util::GetStringUTF16(
- offline_pages::GetOfflinePageFeatureMode() ==
- offline_pages::FeatureMode::ENABLED_AS_BOOKMARKS
- ? IDS_ERRORPAGES_BUTTON_SHOW_OFFLINE_PAGES_AS_BOOKMARKS
- : IDS_ERRORPAGES_BUTTON_SHOW_OFFLINE_PAGES);
- show_offline_pages_button->SetString("msg", button_text);
- error_strings->Set("showOfflinePagesButton", show_offline_pages_button);
- }
-#endif // defined(OS_ANDROID)
-
#if defined(OS_CHROMEOS)
// ChromeOS has its own diagnostics extension, which doesn't rely on a
// browser-initiated dialog.
« no previous file with comments | « chrome/chrome.gyp ('k') | components/error_page_strings.grdp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698