Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1304)

Unified Diff: components/error_page/common/localized_error.cc

Issue 1899433002: Update flags used by offline pages and bookmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/error_page/common/localized_error.cc
diff --git a/components/error_page/common/localized_error.cc b/components/error_page/common/localized_error.cc
index 7285d969c5bea00ee143fe960cf82e5a37484a9d..0f4f9be0b22c12867598206f0ab752655d30da86 100644
--- a/components/error_page/common/localized_error.cc
+++ b/components/error_page/common/localized_error.cc
@@ -1063,10 +1063,7 @@ void LocalizedError::GetStrings(int error_code,
base::DictionaryValue* show_offline_pages_button =
new base::DictionaryValue;
base::string16 button_text = l10n_util::GetStringUTF16(
- offline_pages::GetOfflinePageFeatureMode() ==
- offline_pages::FeatureMode::ENABLED_AS_BOOKMARKS
- ? IDS_ERRORPAGES_BUTTON_SHOW_OFFLINE_PAGES_AS_BOOKMARKS
- : IDS_ERRORPAGES_BUTTON_SHOW_OFFLINE_PAGES);
+ IDS_ERRORPAGES_BUTTON_SHOW_OFFLINE_PAGES_AS_BOOKMARKS);
fgorski 2016/04/18 17:09:37 I am not sure if we still want to point the users
jianli 2016/04/18 21:17:00 I will do it in a separate patch to hide/remove of
show_offline_pages_button->SetString("msg", button_text);
error_strings->Set("showOfflinePagesButton", show_offline_pages_button);
}

Powered by Google App Engine
This is Rietveld 408576698