Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: chrome/browser/about_flags.cc

Issue 1899433002: Update flags used by offline pages and bookmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 37822da2b85dd547a706ba0b03f85ffc404ad223..7cd3034533582a6c42b9cc2b86c7b1eaebf52485 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -44,7 +44,6 @@
#include "components/flags_ui/flags_ui_switches.h"
#include "components/nacl/common/nacl_switches.h"
#include "components/offline_pages/offline_page_feature.h"
-#include "components/offline_pages/offline_page_switches.h"
#include "components/omnibox/browser/omnibox_switches.h"
#include "components/password_manager/core/common/password_manager_features.h"
#include "components/proximity_auth/switches.h"
@@ -486,16 +485,6 @@ const FeatureEntry::Choice kUpdateMenuItemSummaryChoices[] = {
#endif // defined(OS_ANDROID)
#if defined(OS_ANDROID)
-const FeatureEntry::Choice kEnableOfflinePagesChoices[] = {
- {IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""},
- {IDS_FLAGS_ENABLE_OFFLINE_PAGES_AS_BOOKMARKS,
- switches::kEnableOfflinePagesAsBookmarks, ""},
- {IDS_FLAGS_ENABLE_OFFLINE_PAGES_AS_SAVED_PAGES,
- switches::kEnableOfflinePagesAsSavedPages, ""},
- {IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, switches::kDisableOfflinePages,
- ""},
-};
-
const FeatureEntry::Choice kHerbPrototypeChoices[] = {
{IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""},
{IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
@@ -1579,9 +1568,9 @@ const FeatureEntry kFeatureEntries[] = {
MULTI_VALUE_TYPE(kProgressBarAnimationChoices)},
#endif // defined(OS_ANDROID)
#if defined(OS_ANDROID)
- {"offline-pages-mode", IDS_FLAGS_OFFLINE_PAGES_NAME,
- IDS_FLAGS_OFFLINE_PAGES_DESCRIPTION, kOsAndroid,
- MULTI_VALUE_TYPE(kEnableOfflinePagesChoices)},
+ {"offline-bookmarks", IDS_FLAGS_OFFLINE_BOOKMARKS_NAME,
+ IDS_FLAGS_OFFLINE_BOOKMARKS_DESCRIPTION, kOsAndroid,
+ FEATURE_VALUE_TYPE(offline_pages::kOfflineBookmarksFeature)},
{"offline-pages-background-loading",
IDS_FLAGS_OFFLINE_PAGES_BACKGROUND_LOADING_NAME,
IDS_FLAGS_OFFLINE_PAGES_BACKGROUND_LOADING_DESCRIPTION, kOsAndroid,

Powered by Google App Engine
This is Rietveld 408576698