chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java - Issue 1899433002: Update flags used by offline pages and bookmarks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

Issue 1899433002: Update flags used by offline pages and bookmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java ('k') | chrome/app/generated_resources.grd » ('j') | chrome/app/generated_resources.grd » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

index 9333a7c9575e7ef45edf2aab3bc6f70fff26c773..f292a76195f10356dad712779c4519d59637b9e8 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java

@@ -22,7 +22,6 @@ import org.chromium.chrome.browser.snackbar.SnackbarManager;

import org.chromium.chrome.browser.snackbar.SnackbarManager.SnackbarController;

import org.chromium.chrome.browser.tab.Tab;

import org.chromium.chrome.browser.tabmodel.TabModelSelector;

-import org.chromium.components.offlinepages.FeatureMode;

import org.chromium.content_public.browser.LoadUrlParams;

import org.chromium.net.ConnectionType;

import org.chromium.net.NetworkChangeNotifier;

@@ -79,9 +78,6 @@ public class OfflinePageUtils {

if (!OfflinePageBridge.isEnabled()) {

return stringResId;

}

- if (OfflinePageBridge.getFeatureMode() != FeatureMode.ENABLED_AS_SAVED_PAGES) {

- return stringResId;

- }

if (stringResId == R.string.bookmark_action_bar_delete) {

return R.string.offline_pages_action_bar_delete;

} else if (stringResId == R.string.bookmark_action_bar_move) {