third_party/WebKit/Source/modules/imagecapture/ImageCapture.h - Issue 1899403002: MediaStream Image Capture (2): Platform::ImageCaptureFrameGrabber and grabFrame()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/imagecapture/ImageCapture.h

Issue 1899403002: MediaStream Image Capture (2): Platform::ImageCaptureFrameGrabber and grabFrame() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: reillyg@ comments and made SkBitmap immutable Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/imagecapture/ImageCapture-grabFrame.html ('K') | « third_party/WebKit/Source/core/frame/ImageBitmap.cpp ('k') | third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp » ('j') | third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/imagecapture/ImageCapture.h

diff --git a/third_party/WebKit/Source/modules/imagecapture/ImageCapture.h b/third_party/WebKit/Source/modules/imagecapture/ImageCapture.h

index fd89bd0d8188d15d642b313885cbcb23a52800ab..16633e5bef94b7a9f0d52b219f96035825dd7586 100644

--- a/third_party/WebKit/Source/modules/imagecapture/ImageCapture.h

+++ b/third_party/WebKit/Source/modules/imagecapture/ImageCapture.h

@@ -17,6 +17,7 @@ namespace blink {

class ExceptionState;

class MediaStreamTrack;

+class WebImageCaptureFrameGrabber;

// TODO(mcasas): Consideradding a LayoutTest checking that this class is not

// garbage collected while it has event listeners.

@@ -53,6 +54,7 @@ private:

bool addEventListenerInternal(const AtomicString& eventType, EventListener*, const EventListenerOptions&) override;

Member<MediaStreamTrack> m_streamTrack;

+ OwnPtr<WebImageCaptureFrameGrabber> m_frameGrabber;

};

} // namespace blink