third_party/WebKit/LayoutTests/fast/imagecapture/ImageCapture-grabFrame.html - Issue 1899403002: MediaStream Image Capture (2): Platform::ImageCaptureFrameGrabber and grabFrame()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/imagecapture/ImageCapture-grabFrame.html

Issue 1899403002: MediaStream Image Capture (2): Platform::ImageCaptureFrameGrabber and grabFrame() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: emircan@ comments and using SkImage (ref counted) instead of SkBitmap (moveable-non-copyable) throu… Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/imagecapture/ImageCapture-creationAndGrabFrame.html ('k') | third_party/WebKit/Source/core/frame/ImageBitmap.h » ('j') | third_party/WebKit/Source/core/frame/ImageBitmap.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src=../../resources/testharness.js></script>

	3 <script src=../../resources/testharnessreport.js></script>

	4 <body>

	5 <canvas id='canvas0' width=10 height=10/>

	6 </body>

	7 <script>

	8

	9 // This test verifies that ImageCapture can grabFrame()s.

	10

	11 var test = async_test(function() {

	12 var canvas = document.getElementById('canvas0');

	13 // We need to paint something on the canvas to force it to create a context.
	Justin Novosad 2016/04/27 15:03:17 This comment smells like there is an underlying bu This comment smells like there is an underlying bug. The implementation of canvas does defer the allocation of it's image buffer, but that behavior is an optimization that should not have side effects that are observable in JavaScript. Is there a bug about this? mcasas 2016/04/27 17:48:18 What I meant is that canvas.captureStream() in l. Show quoted text On 2016/04/27 15:03:17, Justin Novosad wrote: > This comment smells like there is an underlying bug. The implementation of > canvas does defer the allocation of it's image buffer, but that behavior is an > optimization that should not have side effects that are observable in > JavaScript. Is there a bug about this? What I meant is that canvas.captureStream() in l.16 needs something painted on the canvas to work correctly (emircan@ dixit). No bug AFAIK, I was told this is a WAI. Rewritten for clarity.
	14 canvas.getContext("2d").fillRect(0, 0, 1, 1);

	15

	16 var stream = canvas.captureStream();

	17 var capturer = new ImageCapture(stream.getVideoTracks()[0]);

	18

	19 capturer.grabFrame()

	20 .then(bitmap => {

	21 assert_equals(document.getElementById('canvas0').width, bitmap.width);

	22 assert_equals(document.getElementById('canvas0').height, bitmap.height);
	Justin Novosad 2016/04/27 15:03:17 Test is incomplete. You should verify that the pix Test is incomplete. You should verify that the pixel values were correctly copied all the way through. To do that, you should draw 'bitmap' into a fresh canvas and call getImageData on that canvas to inspect the values. mcasas 2016/04/27 17:48:18 Done. Show quoted text On 2016/04/27 15:03:17, Justin Novosad wrote: > Test is incomplete. You should verify that the pixel values were correctly > copied all the way through. To do that, you should draw 'bitmap' into a fresh > canvas and call getImageData on that canvas to inspect the values. Done.
	23 this.done();

	24 })

	25 .catch(error => {

	26 assert_unreached('Error during grabFrame(): '+ error);

	27 });

	28 }, 'exercises the ImageCapture API creation and grabFrame().');

	29

	30 </script>

OLD	NEW