MediaStream Image Capture (2): Platform::ImageCaptureFrameGrabber and grabFrame()

third_party/WebKit/Source/core/frame/ImageBitmap.cpp

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/frame/ImageBitmap.h"
 
 #include "core/html/HTMLCanvasElement.h"
 #include "core/html/HTMLVideoElement.h"
 #include "core/html/ImageData.h"
 #include "platform/image-decoders/ImageDecoder.h"
@@ skipping 384 matching lines @@
 }
 
 void ImageBitmap::close()
 {
     if (!m_image || m_isNeutered)
         return;
     m_image.clear();
     m_isNeutered = true;
 }
 
+// static
+ImageBitmap* ImageBitmap::take(ScriptPromiseResolver*, PassOwnPtr<SkBitmap> bitmap)
+{
+    RefPtr<StaticBitmapImage> image = StaticBitmapImage::create(
+        adoptRef(SkImage::NewFromBitmap(*bitmap.leakPtr())));

[Reilly Grant (use Gerrit), 2016/04/25 22:37:33]

I think you just want SkImage::NewFromBitmap(*bitmap). It seems like the pixels
will be shared with the new SkImage if necessary but I'm not an expert in the
Skia API.

[mcasas, 2016/04/27 00:51:29]

Done.

+
+    return ImageBitmap::create(image.release());

[Reilly Grant (use Gerrit), 2016/04/25 22:37:33]

It shouldn't be necessary to call release here. The RefPtr<StaticBitmapImage>
will implicitly cast to a PassRefPtr<StaticBitmapImage>.

[mcasas, 2016/04/27 00:51:28]

Done.

+}
+
 PassOwnPtr<uint8_t[]> ImageBitmap::copyBitmapData(AlphaDisposition alphaOp)
 {
     SkImageInfo info = SkImageInfo::Make(width(), height(), kRGBA_8888_SkColorType, (alphaOp == PremultiplyAlpha) ? kPremul_SkAlphaType : kUnpremul_SkAlphaType);
     OwnPtr<uint8_t[]> dstPixels = copySkImageData(m_image->imageForCurrentFrame().get(), info);
     return dstPixels.release();
 }
 
 unsigned long ImageBitmap::width() const
 {
     if (!m_image)
@@ skipping 56 matching lines @@
 FloatSize ImageBitmap::elementSize(const FloatSize&) const
 {
     return FloatSize(width(), height());
 }
 
 DEFINE_TRACE(ImageBitmap)
 {
 }
 
 } // namespace blink