Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 1899393002: Turn off flushes and sharing for the android GLHelper context. (Closed)

Created:
4 years, 8 months ago by danakj
Modified:
4 years, 8 months ago
Reviewers:
no sievers, piman
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su, dcheng, Ken Russell (switch to Gerrit), piman, Zhenyao Mo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn off flushes and sharing for the android GLHelper context. GLHelper doesn't rely on automatic flushes, that is a WebGL thing. And we use mailboxes, so we don't need to be in a global share group with the context. R=sievers@chromium.org BUG=584497 Committed: https://crrev.com/27445896070cac862d23a65f3ce44ffee7501b6d Cr-Commit-Position: refs/heads/master@{#388637}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
danakj
4 years, 8 months ago (2016-04-20 02:19:48 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899393002/1
4 years, 8 months ago (2016-04-20 02:20:05 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-20 03:19:24 UTC) #5
piman
lgtm
4 years, 8 months ago (2016-04-20 22:11:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899393002/1
4 years, 8 months ago (2016-04-20 22:13:02 UTC) #9
no sievers
lgtm
4 years, 8 months ago (2016-04-20 23:35:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 00:31:03 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:29:08 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27445896070cac862d23a65f3ce44ffee7501b6d
Cr-Commit-Position: refs/heads/master@{#388637}

Powered by Google App Engine
This is Rietveld 408576698