Chromium Code Reviews
Description[Merge M51] aw: Use functor released callback for lifetime management
This is a smaller CL for merging to m51 branch. Has similar caveats to
r386831 so not restating them here.
This CL does these things:
* Expose the new callback from android on the callDrawGlFunction
function.
* Use the callback only as a strong reference to keep view
CleanupReferences alive. The actual callback is a no-op for now.
* AwGLFunctor will always hold a the NativeGLDelegate and ContainerView
This is important in case destroy comes after detach.
* AwContents.DestroyRunnable only holds the DestroyRunnable of
AwGLFunctor instead of AwGLFunctor itself to prevent GC leaks.
BUG=597167
TBR=tobiasjs@chromium.org
Review URL: https://codereview.chromium.org/1890343003
Cr-Commit-Position: refs/heads/master@{#387926}
(cherry picked from commit c748c90944d0a21be20b4a0d8844e51bc828f659)
Committed: https://chromium.googlesource.com/chromium/src/+/74af09d91fec7a5d27e3d7def6805414b0a16a81
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||