Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 1899383002: [Merge M51] aw: Use functor released callback for lifetime management (Closed)

Created:
4 years, 8 months ago by boliu
Modified:
4 years, 8 months ago
Reviewers:
Tobias Sargeant
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

[Merge M51] aw: Use functor released callback for lifetime management This is a smaller CL for merging to m51 branch. Has similar caveats to r386831 so not restating them here. This CL does these things: * Expose the new callback from android on the callDrawGlFunction function. * Use the callback only as a strong reference to keep view CleanupReferences alive. The actual callback is a no-op for now. * AwGLFunctor will always hold a the NativeGLDelegate and ContainerView This is important in case destroy comes after detach. * AwContents.DestroyRunnable only holds the DestroyRunnable of AwGLFunctor instead of AwGLFunctor itself to prevent GC leaks. BUG=597167 TBR=tobiasjs@chromium.org Review URL: https://codereview.chromium.org/1890343003 Cr-Commit-Position: refs/heads/master@{#387926} (cherry picked from commit c748c90944d0a21be20b4a0d8844e51bc828f659) Committed: https://chromium.googlesource.com/chromium/src/+/74af09d91fec7a5d27e3d7def6805414b0a16a81

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
boliu
4 years, 8 months ago (2016-04-20 01:59:00 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
74af09d91fec7a5d27e3d7def6805414b0a16a81.

Powered by Google App Engine
This is Rietveld 408576698