Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: test/codegen/language/getter_override3_test.dart

Issue 1899373002: Emit forwarding getter/setter when overriding just a getter or setter. (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/codegen/expect/language-all.js ('k') | test/codegen/language/setter_override3_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/codegen/language/getter_override3_test.dart
diff --git a/test/codegen/language/field_super_access_test.dart b/test/codegen/language/getter_override3_test.dart
similarity index 63%
copy from test/codegen/language/field_super_access_test.dart
copy to test/codegen/language/getter_override3_test.dart
index 63a958670315aeee0c560ff278f9d3814a8862ad..c17b27e7fd1881d6020937851fb5362776de7a69 100644
--- a/test/codegen/language/field_super_access_test.dart
+++ b/test/codegen/language/getter_override3_test.dart
@@ -2,22 +2,25 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-// Tests that a super call to access a field in a super class is just a normal
-// field access.
-
+// Tests that a getter in a subclass does not shadow the setter in the
+// superclass.
import "package:expect/expect.dart";
class A {
- int y;
+ int _x = 42;
+ void set x(int val) {
+ _x = val;
+ }
}
class B extends A {
- int get x => super.y;
- void set x(val) { super.y = val; }
+ int get x => _x;
}
void main() {
var b = new B();
- b.x = 42;
Expect.equals(42, b.x);
+
+ b.x = 21;
+ Expect.equals(21, b.x);
}
« no previous file with comments | « test/codegen/expect/language-all.js ('k') | test/codegen/language/setter_override3_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698