Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Unified Diff: lib/runtime/dart_sdk.js

Issue 1899373002: Emit forwarding getter/setter when overriding just a getter or setter. (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | lib/src/compiler/code_generator.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart_sdk.js
diff --git a/lib/runtime/dart_sdk.js b/lib/runtime/dart_sdk.js
index bc6f793eac4eb7e986ef2a40ab34c85bd5e3e6a4..eaf7afaa63c93680037faee732de1f018a6db0ce 100644
--- a/lib/runtime/dart_sdk.js
+++ b/lib/runtime/dart_sdk.js
@@ -4057,6 +4057,9 @@ dart_library.library('dart_sdk', null, /* Imports */[
get length() {
return this[_string][dartx.length];
}
+ set length(value) {
+ super.length = value;
+ }
get(i) {
return this[_string][dartx.codeUnitAt](i);
}
@@ -17491,6 +17494,7 @@ dart_library.library('dart_sdk', null, /* Imports */[
fork: [async.Zone, [async.Zone, async.ZoneSpecification, core.Map]]
})
});
+ const _map = Symbol('_map');
async._Zone = class _Zone extends core.Object {
_Zone() {
}
@@ -17504,7 +17508,6 @@ dart_library.library('dart_sdk', null, /* Imports */[
methods: () => ({inSameErrorZone: [core.bool, [async.Zone]]})
});
const _delegateCache = Symbol('_delegateCache');
- const _map = Symbol('_map');
async._CustomZone = class _CustomZone extends async._Zone {
get [_delegate]() {
if (this[_delegateCache] != null) return this[_delegateCache];
@@ -20269,6 +20272,9 @@ dart_library.library('dart_sdk', null, /* Imports */[
get length() {
return this[_source$0][dartx.length];
}
+ set length(value) {
+ super.length = value;
+ }
get(index) {
return this[_source$0][dartx.elementAt](index);
}
@@ -22186,6 +22192,7 @@ dart_library.library('dart_sdk', null, /* Imports */[
const _root = Symbol('_root');
const _count = Symbol('_count');
const _splayCount = Symbol('_splayCount');
+ const _comparator = Symbol('_comparator');
const _compare = Symbol('_compare');
const _splay = Symbol('_splay');
const _splayMin = Symbol('_splayMin');
@@ -22337,7 +22344,6 @@ dart_library.library('dart_sdk', null, /* Imports */[
return _SplayTree;
});
collection._SplayTree = collection._SplayTree$();
- const _comparator = Symbol('_comparator');
collection.SplayTreeMap$ = dart.generic((K, V) => {
class SplayTreeMap extends collection._SplayTree$(K) {
SplayTreeMap(compare, isValidKey) {
@@ -29851,10 +29857,6 @@ dart_library.library('dart_sdk', null, /* Imports */[
return new (math.Rectangle$(T))(left, top, width, height);
}
}
- dart.virtualField(Rectangle, dartx.left);
- dart.virtualField(Rectangle, dartx.top);
- dart.virtualField(Rectangle, dartx.width);
- dart.virtualField(Rectangle, dartx.height);
dart.setSignature(Rectangle, {
constructors: () => ({
Rectangle: [math.Rectangle$(T), [T, T, T, T]],
@@ -29899,8 +29901,6 @@ dart_library.library('dart_sdk', null, /* Imports */[
this[_height] = height;
}
}
- dart.virtualField(MutableRectangle, 'left');
- dart.virtualField(MutableRectangle, 'top');
MutableRectangle[dart.implements] = () => [math.Rectangle$(T)];
dart.setSignature(MutableRectangle, {
constructors: () => ({
@@ -57807,7 +57807,6 @@ dart_library.library('dart_sdk', null, /* Imports */[
html$.ShadowRoot._shadowRootDeprecationReport();
}
};
- dart.virtualField(html$.ShadowRoot, dartx.innerHtml);
dart.setSignature(html$.ShadowRoot, {
constructors: () => ({_: [html$.ShadowRoot, []]}),
methods: () => ({
@@ -65279,9 +65278,15 @@ dart_library.library('dart_sdk', null, /* Imports */[
set height(newHeight) {
this[_elementList][dartx.forEach](dart.fn(e => e[dartx.contentEdge].height = newHeight, dart.void, [html$.Element]));
}
+ get height() {
+ return super.height;
+ }
set width(newWidth) {
this[_elementList][dartx.forEach](dart.fn(e => e[dartx.contentEdge].width = newWidth, dart.void, [html$.Element]));
}
+ get width() {
+ return super.width;
+ }
};
dart.setSignature(html$._ContentCssListRect, {
constructors: () => ({_ContentCssListRect: [html$._ContentCssListRect, [core.List$(html$.Element)]]})
@@ -65293,9 +65298,15 @@ dart_library.library('dart_sdk', null, /* Imports */[
get height() {
return dart.notNull(this[_element$][dartx.offsetHeight]) + dart.notNull(this[_addOrSubtractToBoxModel](html$._HEIGHT, html$._PADDING));
}
+ set height(value) {
+ super.height = value;
+ }
get width() {
return dart.notNull(this[_element$][dartx.offsetWidth]) + dart.notNull(this[_addOrSubtractToBoxModel](html$._WIDTH, html$._PADDING));
}
+ set width(value) {
+ super.width = value;
+ }
get left() {
return dart.notNull(this[_element$][dartx.getBoundingClientRect]()[dartx.left]) - dart.notNull(this[_addOrSubtractToBoxModel](dart.list(['left'], core.String), html$._PADDING));
}
@@ -65314,9 +65325,15 @@ dart_library.library('dart_sdk', null, /* Imports */[
get height() {
return this[_element$][dartx.offsetHeight];
}
+ set height(value) {
+ super.height = value;
+ }
get width() {
return this[_element$][dartx.offsetWidth];
}
+ set width(value) {
+ super.width = value;
+ }
get left() {
return this[_element$][dartx.getBoundingClientRect]()[dartx.left];
}
@@ -65335,9 +65352,15 @@ dart_library.library('dart_sdk', null, /* Imports */[
get height() {
return dart.notNull(this[_element$][dartx.offsetHeight]) + dart.notNull(this[_addOrSubtractToBoxModel](html$._HEIGHT, html$._MARGIN));
}
+ set height(value) {
+ super.height = value;
+ }
get width() {
return dart.notNull(this[_element$][dartx.offsetWidth]) + dart.notNull(this[_addOrSubtractToBoxModel](html$._WIDTH, html$._MARGIN));
}
+ set width(value) {
+ super.width = value;
+ }
get left() {
return dart.notNull(this[_element$][dartx.getBoundingClientRect]()[dartx.left]) - dart.notNull(this[_addOrSubtractToBoxModel](dart.list(['left'], core.String), html$._MARGIN));
}
« no previous file with comments | « no previous file | lib/src/compiler/code_generator.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698