Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: lib/runtime/dart_sdk.js

Side-by-side diff isn't available for this file because of its large size.
Issue 1899373002: Emit forwarding getter/setter when overriding just a getter or setter. (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: fix complex setters/getters Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | lib/src/compiler/code_generator.dart » ('j') | lib/src/compiler/code_generator.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart_sdk.js
diff --git a/lib/runtime/dart_sdk.js b/lib/runtime/dart_sdk.js
index 9983df9e5102482737cc09eb0c5bf64fc98c4d10..6df691347502d7da0b39d3abfdace4a5483df022 100644
--- a/lib/runtime/dart_sdk.js
+++ b/lib/runtime/dart_sdk.js
@@ -4058,6 +4058,9 @@ dart_library.library('dart_sdk', null, /* Imports */[
get length() {
return this[_string][dartx.length];
}
+ set length(value) {
+ super.length = value;
Harry Terkelsen 2016/04/20 00:57:36 it looks like ddc is smart enough to rewrite a['b'
Jennifer Messerly 2016/04/20 21:16:39 yes we get this "for free" from js_ast code taken
Harry Terkelsen 2016/04/20 23:33:27 Acknowledged.
+ }
get(i) {
return this[_string][dartx.codeUnitAt](i);
}
@@ -10968,6 +10971,9 @@ dart_library.library('dart_sdk', null, /* Imports */[
get length() {
return (dart.notNull(this[_storage][dartx.length]) / 4)[dartx.truncate]();
}
+ set length(value) {
+ super.length = value;
+ }
get(index) {
this[_checkIndex](index, this.length);
let _x = this[_storage][dartx.get](dart.notNull(index) * 4 + 0);
@@ -11357,6 +11363,9 @@ dart_library.library('dart_sdk', null, /* Imports */[
get length() {
return (dart.notNull(this[_storage][dartx.length]) / 4)[dartx.truncate]();
}
+ set length(value) {
+ super.length = value;
+ }
get(index) {
this[_checkIndex](index, this.length);
let _x = this[_storage][dartx.get](dart.notNull(index) * 4 + 0);
@@ -11492,6 +11501,9 @@ dart_library.library('dart_sdk', null, /* Imports */[
get length() {
return (dart.notNull(this[_storage][dartx.length]) / 2)[dartx.truncate]();
}
+ set length(value) {
+ super.length = value;
+ }
get(index) {
this[_checkIndex](index, this.length);
let _x = this[_storage][dartx.get](dart.notNull(index) * 2 + 0);
@@ -11871,6 +11883,9 @@ dart_library.library('dart_sdk', null, /* Imports */[
get [dartx.length]() {
return this.length;
}
+ set [dartx.length](value) {
+ super[dartx.length] = value;
+ }
[dartx.get](index) {
this[_checkIndex](index, this[dartx.length]);
return this[index];
@@ -11905,6 +11920,9 @@ dart_library.library('dart_sdk', null, /* Imports */[
get [dartx.length]() {
return this.length;
}
+ set [dartx.length](value) {
+ super[dartx.length] = value;
+ }
[dartx.set](index, value) {
this[_checkIndex](index, this[dartx.length]);
this[index] = value;
@@ -12346,6 +12364,9 @@ dart_library.library('dart_sdk', null, /* Imports */[
get [dartx.length]() {
return this.length;
}
+ set [dartx.length](value) {
+ super[dartx.length] = value;
+ }
[dartx.get](index) {
this[_checkIndex](index, this[dartx.length]);
return this[index];
@@ -12409,6 +12430,9 @@ dart_library.library('dart_sdk', null, /* Imports */[
get [dartx.length]() {
return this.length;
}
+ set [dartx.length](value) {
+ super[dartx.length] = value;
+ }
[dartx.get](index) {
this[_checkIndex](index, this[dartx.length]);
return this[index];
@@ -20270,6 +20294,9 @@ dart_library.library('dart_sdk', null, /* Imports */[
get length() {
return this[_source$0][dartx.length];
}
+ set length(value) {
+ super.length = value;
+ }
get(index) {
return this[_source$0][dartx.elementAt](index);
}
@@ -29852,10 +29879,6 @@ dart_library.library('dart_sdk', null, /* Imports */[
return new (math.Rectangle$(T))(left, top, width, height);
}
}
- dart.virtualField(Rectangle, dartx.left);
- dart.virtualField(Rectangle, dartx.top);
- dart.virtualField(Rectangle, dartx.width);
- dart.virtualField(Rectangle, dartx.height);
dart.setSignature(Rectangle, {
constructors: () => ({
Rectangle: [math.Rectangle$(T), [T, T, T, T]],
@@ -29900,8 +29923,6 @@ dart_library.library('dart_sdk', null, /* Imports */[
this[_height] = height;
}
}
- dart.virtualField(MutableRectangle, 'left');
- dart.virtualField(MutableRectangle, 'top');
MutableRectangle[dart.implements] = () => [math.Rectangle$(T)];
dart.setSignature(MutableRectangle, {
constructors: () => ({
@@ -41039,273 +41060,543 @@ dart_library.library('dart_sdk', null, /* Imports */[
set background(value) {
this[_setAll]('background', value);
}
+ get background() {
+ return super.background;
+ }
set backgroundAttachment(value) {
this[_setAll]('backgroundAttachment', value);
}
+ get backgroundAttachment() {
+ return super.backgroundAttachment;
+ }
set backgroundColor(value) {
this[_setAll]('backgroundColor', value);
}
+ get backgroundColor() {
+ return super.backgroundColor;
+ }
set backgroundImage(value) {
this[_setAll]('backgroundImage', value);
}
+ get backgroundImage() {
+ return super.backgroundImage;
+ }
set backgroundPosition(value) {
this[_setAll]('backgroundPosition', value);
}
+ get backgroundPosition() {
+ return super.backgroundPosition;
+ }
set backgroundRepeat(value) {
this[_setAll]('backgroundRepeat', value);
}
+ get backgroundRepeat() {
+ return super.backgroundRepeat;
+ }
set border(value) {
this[_setAll]('border', value);
}
+ get border() {
+ return super.border;
+ }
set borderBottom(value) {
this[_setAll]('borderBottom', value);
}
+ get borderBottom() {
+ return super.borderBottom;
+ }
set borderBottomColor(value) {
this[_setAll]('borderBottomColor', value);
}
+ get borderBottomColor() {
+ return super.borderBottomColor;
+ }
set borderBottomStyle(value) {
this[_setAll]('borderBottomStyle', value);
}
+ get borderBottomStyle() {
+ return super.borderBottomStyle;
+ }
set borderBottomWidth(value) {
this[_setAll]('borderBottomWidth', value);
}
+ get borderBottomWidth() {
+ return super.borderBottomWidth;
+ }
set borderCollapse(value) {
this[_setAll]('borderCollapse', value);
}
+ get borderCollapse() {
+ return super.borderCollapse;
+ }
set borderColor(value) {
this[_setAll]('borderColor', value);
}
+ get borderColor() {
+ return super.borderColor;
+ }
set borderLeft(value) {
this[_setAll]('borderLeft', value);
}
+ get borderLeft() {
+ return super.borderLeft;
+ }
set borderLeftColor(value) {
this[_setAll]('borderLeftColor', value);
}
+ get borderLeftColor() {
+ return super.borderLeftColor;
+ }
set borderLeftStyle(value) {
this[_setAll]('borderLeftStyle', value);
}
+ get borderLeftStyle() {
+ return super.borderLeftStyle;
+ }
set borderLeftWidth(value) {
this[_setAll]('borderLeftWidth', value);
}
+ get borderLeftWidth() {
+ return super.borderLeftWidth;
+ }
set borderRight(value) {
this[_setAll]('borderRight', value);
}
+ get borderRight() {
+ return super.borderRight;
+ }
set borderRightColor(value) {
this[_setAll]('borderRightColor', value);
}
+ get borderRightColor() {
+ return super.borderRightColor;
+ }
set borderRightStyle(value) {
this[_setAll]('borderRightStyle', value);
}
+ get borderRightStyle() {
+ return super.borderRightStyle;
+ }
set borderRightWidth(value) {
this[_setAll]('borderRightWidth', value);
}
+ get borderRightWidth() {
+ return super.borderRightWidth;
+ }
set borderSpacing(value) {
this[_setAll]('borderSpacing', value);
}
+ get borderSpacing() {
+ return super.borderSpacing;
+ }
set borderStyle(value) {
this[_setAll]('borderStyle', value);
}
+ get borderStyle() {
+ return super.borderStyle;
+ }
set borderTop(value) {
this[_setAll]('borderTop', value);
}
+ get borderTop() {
+ return super.borderTop;
+ }
set borderTopColor(value) {
this[_setAll]('borderTopColor', value);
}
+ get borderTopColor() {
+ return super.borderTopColor;
+ }
set borderTopStyle(value) {
this[_setAll]('borderTopStyle', value);
}
+ get borderTopStyle() {
+ return super.borderTopStyle;
+ }
set borderTopWidth(value) {
this[_setAll]('borderTopWidth', value);
}
+ get borderTopWidth() {
+ return super.borderTopWidth;
+ }
set borderWidth(value) {
this[_setAll]('borderWidth', value);
}
+ get borderWidth() {
+ return super.borderWidth;
+ }
set bottom(value) {
this[_setAll]('bottom', value);
}
+ get bottom() {
+ return super.bottom;
+ }
set captionSide(value) {
this[_setAll]('captionSide', value);
}
+ get captionSide() {
+ return super.captionSide;
+ }
set clear(value) {
this[_setAll]('clear', value);
}
+ get clear() {
+ return super.clear;
+ }
set clip(value) {
this[_setAll]('clip', value);
}
+ get clip() {
+ return super.clip;
+ }
set color(value) {
this[_setAll]('color', value);
}
+ get color() {
+ return super.color;
+ }
set content(value) {
this[_setAll]('content', value);
}
+ get content() {
+ return super.content;
+ }
set cursor(value) {
this[_setAll]('cursor', value);
}
+ get cursor() {
+ return super.cursor;
+ }
set direction(value) {
this[_setAll]('direction', value);
}
+ get direction() {
+ return super.direction;
+ }
set display(value) {
this[_setAll]('display', value);
}
+ get display() {
+ return super.display;
+ }
set emptyCells(value) {
this[_setAll]('emptyCells', value);
}
+ get emptyCells() {
+ return super.emptyCells;
+ }
set font(value) {
this[_setAll]('font', value);
}
+ get font() {
+ return super.font;
+ }
set fontFamily(value) {
this[_setAll]('fontFamily', value);
}
+ get fontFamily() {
+ return super.fontFamily;
+ }
set fontSize(value) {
this[_setAll]('fontSize', value);
}
+ get fontSize() {
+ return super.fontSize;
+ }
set fontStyle(value) {
this[_setAll]('fontStyle', value);
}
+ get fontStyle() {
+ return super.fontStyle;
+ }
set fontVariant(value) {
this[_setAll]('fontVariant', value);
}
+ get fontVariant() {
+ return super.fontVariant;
+ }
set fontWeight(value) {
this[_setAll]('fontWeight', value);
}
+ get fontWeight() {
+ return super.fontWeight;
+ }
set height(value) {
this[_setAll]('height', value);
}
+ get height() {
+ return super.height;
+ }
set left(value) {
this[_setAll]('left', value);
}
+ get left() {
+ return super.left;
+ }
set letterSpacing(value) {
this[_setAll]('letterSpacing', value);
}
+ get letterSpacing() {
+ return super.letterSpacing;
+ }
set lineHeight(value) {
this[_setAll]('lineHeight', value);
}
+ get lineHeight() {
+ return super.lineHeight;
+ }
set listStyle(value) {
this[_setAll]('listStyle', value);
}
+ get listStyle() {
+ return super.listStyle;
+ }
set listStyleImage(value) {
this[_setAll]('listStyleImage', value);
}
+ get listStyleImage() {
+ return super.listStyleImage;
+ }
set listStylePosition(value) {
this[_setAll]('listStylePosition', value);
}
+ get listStylePosition() {
+ return super.listStylePosition;
+ }
set listStyleType(value) {
this[_setAll]('listStyleType', value);
}
+ get listStyleType() {
+ return super.listStyleType;
+ }
set margin(value) {
this[_setAll]('margin', value);
}
+ get margin() {
+ return super.margin;
+ }
set marginBottom(value) {
this[_setAll]('marginBottom', value);
}
+ get marginBottom() {
+ return super.marginBottom;
+ }
set marginLeft(value) {
this[_setAll]('marginLeft', value);
}
+ get marginLeft() {
+ return super.marginLeft;
+ }
set marginRight(value) {
this[_setAll]('marginRight', value);
}
+ get marginRight() {
+ return super.marginRight;
+ }
set marginTop(value) {
this[_setAll]('marginTop', value);
}
+ get marginTop() {
+ return super.marginTop;
+ }
set maxHeight(value) {
this[_setAll]('maxHeight', value);
}
+ get maxHeight() {
+ return super.maxHeight;
+ }
set maxWidth(value) {
this[_setAll]('maxWidth', value);
}
+ get maxWidth() {
+ return super.maxWidth;
+ }
set minHeight(value) {
this[_setAll]('minHeight', value);
}
+ get minHeight() {
+ return super.minHeight;
+ }
set minWidth(value) {
this[_setAll]('minWidth', value);
}
+ get minWidth() {
+ return super.minWidth;
+ }
set outline(value) {
this[_setAll]('outline', value);
}
+ get outline() {
+ return super.outline;
+ }
set outlineColor(value) {
this[_setAll]('outlineColor', value);
}
+ get outlineColor() {
+ return super.outlineColor;
+ }
set outlineStyle(value) {
this[_setAll]('outlineStyle', value);
}
+ get outlineStyle() {
+ return super.outlineStyle;
+ }
set outlineWidth(value) {
this[_setAll]('outlineWidth', value);
}
+ get outlineWidth() {
+ return super.outlineWidth;
+ }
set overflow(value) {
this[_setAll]('overflow', value);
}
+ get overflow() {
+ return super.overflow;
+ }
set padding(value) {
this[_setAll]('padding', value);
}
+ get padding() {
+ return super.padding;
+ }
set paddingBottom(value) {
this[_setAll]('paddingBottom', value);
}
+ get paddingBottom() {
+ return super.paddingBottom;
+ }
set paddingLeft(value) {
this[_setAll]('paddingLeft', value);
}
+ get paddingLeft() {
+ return super.paddingLeft;
+ }
set paddingRight(value) {
this[_setAll]('paddingRight', value);
}
+ get paddingRight() {
+ return super.paddingRight;
+ }
set paddingTop(value) {
this[_setAll]('paddingTop', value);
}
+ get paddingTop() {
+ return super.paddingTop;
+ }
set pageBreakAfter(value) {
this[_setAll]('pageBreakAfter', value);
}
+ get pageBreakAfter() {
+ return super.pageBreakAfter;
+ }
set pageBreakBefore(value) {
this[_setAll]('pageBreakBefore', value);
}
+ get pageBreakBefore() {
+ return super.pageBreakBefore;
+ }
set pageBreakInside(value) {
this[_setAll]('pageBreakInside', value);
}
+ get pageBreakInside() {
+ return super.pageBreakInside;
+ }
set position(value) {
this[_setAll]('position', value);
}
+ get position() {
+ return super.position;
+ }
set quotes(value) {
this[_setAll]('quotes', value);
}
+ get quotes() {
+ return super.quotes;
+ }
set right(value) {
this[_setAll]('right', value);
}
+ get right() {
+ return super.right;
+ }
set tableLayout(value) {
this[_setAll]('tableLayout', value);
}
+ get tableLayout() {
+ return super.tableLayout;
+ }
set textAlign(value) {
this[_setAll]('textAlign', value);
}
+ get textAlign() {
+ return super.textAlign;
+ }
set textDecoration(value) {
this[_setAll]('textDecoration', value);
}
+ get textDecoration() {
+ return super.textDecoration;
+ }
set textIndent(value) {
this[_setAll]('textIndent', value);
}
+ get textIndent() {
+ return super.textIndent;
+ }
set textTransform(value) {
this[_setAll]('textTransform', value);
}
+ get textTransform() {
+ return super.textTransform;
+ }
set top(value) {
this[_setAll]('top', value);
}
+ get top() {
+ return super.top;
+ }
set unicodeBidi(value) {
this[_setAll]('unicodeBidi', value);
}
+ get unicodeBidi() {
+ return super.unicodeBidi;
+ }
set verticalAlign(value) {
this[_setAll]('verticalAlign', value);
}
+ get verticalAlign() {
+ return super.verticalAlign;
+ }
set visibility(value) {
this[_setAll]('visibility', value);
}
+ get visibility() {
+ return super.visibility;
+ }
set whiteSpace(value) {
this[_setAll]('whiteSpace', value);
}
+ get whiteSpace() {
+ return super.whiteSpace;
+ }
set width(value) {
this[_setAll]('width', value);
}
+ get width() {
+ return super.width;
+ }
set wordSpacing(value) {
this[_setAll]('wordSpacing', value);
}
+ get wordSpacing() {
+ return super.wordSpacing;
+ }
set zIndex(value) {
this[_setAll]('zIndex', value);
}
+ get zIndex() {
+ return super.zIndex;
+ }
};
dart.setSignature(html$._CssStyleDeclarationSet, {
constructors: () => ({_CssStyleDeclarationSet: [html$._CssStyleDeclarationSet, [core.Iterable$(html$.Element)]]}),
@@ -62910,6 +63201,12 @@ dart_library.library('dart_sdk', null, /* Imports */[
this[_element$] = element;
super.MutableRectangle(0, 0, 0, 0);
}
+ set left(value) {
+ super.left = value;
+ }
+ set top(value) {
+ super.top = value;
+ }
set height(newHeight) {
dart.throw(new core.UnsupportedError("Can only set height for content rect."));
}
@@ -62986,9 +63283,15 @@ dart_library.library('dart_sdk', null, /* Imports */[
set height(newHeight) {
this[_elementList][dartx.forEach](dart.fn(e => e[dartx.contentEdge].height = newHeight, core.num, [html$.Element]));
}
+ get height() {
+ return super.height;
+ }
set width(newWidth) {
this[_elementList][dartx.forEach](dart.fn(e => e[dartx.contentEdge].width = newWidth, core.num, [html$.Element]));
}
+ get width() {
+ return super.width;
+ }
};
dart.setSignature(html$._ContentCssListRect, {
constructors: () => ({_ContentCssListRect: [html$._ContentCssListRect, [dart.dynamic]]})
@@ -63000,9 +63303,15 @@ dart_library.library('dart_sdk', null, /* Imports */[
get height() {
return dart.notNull(this[_element$][dartx.offsetHeight]) + dart.notNull(this[_addOrSubtractToBoxModel](html$._HEIGHT, html$._PADDING));
}
+ set height(value) {
+ super.height = value;
+ }
get width() {
return dart.notNull(this[_element$][dartx.offsetWidth]) + dart.notNull(this[_addOrSubtractToBoxModel](html$._WIDTH, html$._PADDING));
}
+ set width(value) {
+ super.width = value;
+ }
get left() {
return dart.notNull(this[_element$][dartx.getBoundingClientRect]()[dartx.left]) - dart.notNull(this[_addOrSubtractToBoxModel](dart.list(['left'], core.String), html$._PADDING));
}
@@ -63021,9 +63330,15 @@ dart_library.library('dart_sdk', null, /* Imports */[
get height() {
return this[_element$][dartx.offsetHeight];
}
+ set height(value) {
+ super.height = value;
+ }
get width() {
return this[_element$][dartx.offsetWidth];
}
+ set width(value) {
+ super.width = value;
+ }
get left() {
return this[_element$][dartx.getBoundingClientRect]()[dartx.left];
}
@@ -63042,9 +63357,15 @@ dart_library.library('dart_sdk', null, /* Imports */[
get height() {
return dart.notNull(this[_element$][dartx.offsetHeight]) + dart.notNull(this[_addOrSubtractToBoxModel](html$._HEIGHT, html$._MARGIN));
}
+ set height(value) {
+ super.height = value;
+ }
get width() {
return dart.notNull(this[_element$][dartx.offsetWidth]) + dart.notNull(this[_addOrSubtractToBoxModel](html$._WIDTH, html$._MARGIN));
}
+ set width(value) {
+ super.width = value;
+ }
get left() {
return dart.notNull(this[_element$][dartx.getBoundingClientRect]()[dartx.left]) - dart.notNull(this[_addOrSubtractToBoxModel](dart.list(['left'], core.String), html$._MARGIN));
}
@@ -66922,6 +67243,9 @@ dart_library.library('dart_sdk', null, /* Imports */[
get [dartx.classes]() {
return new svg$._AttributeClassSet(this);
}
+ set [dartx.classes](value) {
+ super[dartx.classes] = value;
+ }
get [dartx.children]() {
return new html_common.FilteredElementList(this);
}
« no previous file with comments | « no previous file | lib/src/compiler/code_generator.dart » ('j') | lib/src/compiler/code_generator.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698