Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1899363002: Finish plumbing MojoVideoDecoder. (Closed)

Created:
4 years, 8 months ago by sandersd (OOO until July 31)
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Finish plumbing MojoVideoDecoder. This completes the work to connect from a renderer to the VideoDecoder service in the GPU process, and implements a basic, functional VideoDecoder service. There are no working VideoDecoders to actually instantiate yet, so the service will always return false from Configure(). Later CLs will add command buffer stub sharing and other requirements so that real decoders can be implemented. BUG=522298 Committed: https://crrev.com/e78f9cb7d7bb4709436482572eb6fcb9a795e3b1 Cr-Commit-Position: refs/heads/master@{#395971}

Patch Set 1 #

Patch Set 2 : #

Total comments: 20

Patch Set 3 : Rebase and strip down. #

Total comments: 11

Patch Set 4 : #

Patch Set 5 : Renames #

Patch Set 6 : Spaaace. #

Total comments: 31

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : Rebase. #

Total comments: 4

Patch Set 10 : Rebase. (interfaces:: -> mojom::) #

Patch Set 11 : Remove CHECKs on GPU side. #

Total comments: 10

Patch Set 12 : Rebase. #

Total comments: 4

Patch Set 13 : CHECK -> DCHECK #

Patch Set 14 : Windows needs some more headers, apaprently. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+547 lines, -87 lines) Patch
M content/renderer/media/media_interface_provider.cc View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -0 lines 0 comments Download
M media/base/decoder_factory.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M media/base/decoder_factory.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M media/mojo/common/media_type_converters.cc View 1 2 3 4 5 6 7 8 9 4 chunks +14 lines, -4 lines 0 comments Download
M media/mojo/interfaces/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M media/mojo/interfaces/audio_decoder.mojom View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -7 lines 0 comments Download
M media/mojo/interfaces/media_types.mojom View 1 2 3 4 5 6 7 8 9 2 chunks +8 lines, -1 line 0 comments Download
M media/mojo/interfaces/service_factory.mojom View 1 2 3 4 5 6 7 8 9 2 chunks +4 lines, -0 lines 0 comments Download
A media/mojo/interfaces/video_decoder.mojom View 1 2 3 4 5 6 7 8 9 1 chunk +55 lines, -0 lines 0 comments Download
M media/mojo/services/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -0 lines 0 comments Download
M media/mojo/services/android_mojo_media_client.cc View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -0 lines 0 comments Download
M media/mojo/services/default_mojo_media_client.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M media/mojo/services/mojo_audio_decoder.h View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -1 line 0 comments Download
M media/mojo/services/mojo_audio_decoder.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -17 lines 0 comments Download
M media/mojo/services/mojo_audio_decoder_service.cc View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +2 lines, -16 lines 0 comments Download
M media/mojo/services/mojo_decoder_factory.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M media/mojo/services/mojo_decoder_factory.cc View 1 2 3 4 5 6 7 8 9 1 chunk +7 lines, -3 lines 0 comments Download
M media/mojo/services/mojo_media_client.h View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +13 lines, -6 lines 0 comments Download
M media/mojo/services/mojo_media_client.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +11 lines, -0 lines 0 comments Download
M media/mojo/services/mojo_video_decoder.h View 1 2 3 4 5 6 7 8 9 10 3 chunks +40 lines, -3 lines 0 comments Download
M media/mojo/services/mojo_video_decoder.cc View 1 2 3 4 5 6 7 8 9 2 chunks +138 lines, -18 lines 0 comments Download
A media/mojo/services/mojo_video_decoder_service.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +62 lines, -0 lines 0 comments Download
A media/mojo/services/mojo_video_decoder_service.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +149 lines, -0 lines 0 comments Download
M media/mojo/services/service_factory_impl.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +4 lines, -5 lines 0 comments Download
M media/mojo/services/service_factory_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +12 lines, -0 lines 0 comments Download
M media/mojo/services/test_mojo_media_client.cc View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M media/renderers/default_renderer_factory.cc View 1 2 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 65 (17 generated)
xhwang
The main idea looks good! I have a few comments. I didn't review MojoVideoDecoder* in ...
4 years, 8 months ago (2016-04-20 21:09:27 UTC) #1
sandersd (OOO until July 31)
(A few clarifications) https://chromiumcodereview.appspot.com/1899363002/diff/20001/media/mojo/interfaces/video_decoder.mojom File media/mojo/interfaces/video_decoder.mojom (right): https://chromiumcodereview.appspot.com/1899363002/diff/20001/media/mojo/interfaces/video_decoder.mojom#newcode14 media/mojo/interfaces/video_decoder.mojom:14: // TODO(sandersd): Do we need to ...
4 years, 8 months ago (2016-04-20 21:16:07 UTC) #2
sandersd (OOO until July 31)
I've slimmed this down enough that it may even be commit-able now, depending on what ...
4 years, 7 months ago (2016-05-03 00:54:37 UTC) #5
xhwang
looking good. Just a few more comments/nits. https://chromiumcodereview.appspot.com/1899363002/diff/40001/media/mojo/interfaces/video_decoder.mojom File media/mojo/interfaces/video_decoder.mojom (right): https://chromiumcodereview.appspot.com/1899363002/diff/40001/media/mojo/interfaces/video_decoder.mojom#newcode9 media/mojo/interfaces/video_decoder.mojom:9: interface VideoDecoder ...
4 years, 7 months ago (2016-05-05 17:26:37 UTC) #6
xhwang
Also, please add more details in the CL description.
4 years, 7 months ago (2016-05-05 17:27:08 UTC) #7
sandersd (OOO until July 31)
https://codereview.chromium.org/1899363002/diff/40001/media/mojo/interfaces/video_decoder.mojom File media/mojo/interfaces/video_decoder.mojom (right): https://codereview.chromium.org/1899363002/diff/40001/media/mojo/interfaces/video_decoder.mojom#newcode9 media/mojo/interfaces/video_decoder.mojom:9: interface VideoDecoder { On 2016/05/05 17:26:37, xhwang wrote: > ...
4 years, 7 months ago (2016-05-06 01:23:55 UTC) #8
xhwang
LGTM with a naming discussion. https://chromiumcodereview.appspot.com/1899363002/diff/40001/media/mojo/interfaces/video_decoder.mojom File media/mojo/interfaces/video_decoder.mojom (right): https://chromiumcodereview.appspot.com/1899363002/diff/40001/media/mojo/interfaces/video_decoder.mojom#newcode12 media/mojo/interfaces/video_decoder.mojom:12: Configure(VideoDecoderConfig config, bool low_delay) ...
4 years, 7 months ago (2016-05-06 17:44:44 UTC) #11
sandersd (OOO until July 31)
https://chromiumcodereview.appspot.com/1899363002/diff/40001/media/mojo/interfaces/video_decoder.mojom File media/mojo/interfaces/video_decoder.mojom (right): https://chromiumcodereview.appspot.com/1899363002/diff/40001/media/mojo/interfaces/video_decoder.mojom#newcode12 media/mojo/interfaces/video_decoder.mojom:12: Configure(VideoDecoderConfig config, bool low_delay) => (bool success); On 2016/05/06 ...
4 years, 7 months ago (2016-05-06 18:01:54 UTC) #12
xhwang
On 2016/05/06 18:01:54, sandersd wrote: > https://chromiumcodereview.appspot.com/1899363002/diff/40001/media/mojo/interfaces/video_decoder.mojom > File media/mojo/interfaces/video_decoder.mojom (right): > > https://chromiumcodereview.appspot.com/1899363002/diff/40001/media/mojo/interfaces/video_decoder.mojom#newcode12 > ...
4 years, 7 months ago (2016-05-06 18:05:38 UTC) #13
sandersd (OOO until July 31)
On 2016/05/06 18:05:38, xhwang wrote: > On 2016/05/06 18:01:54, sandersd wrote: > > > https://chromiumcodereview.appspot.com/1899363002/diff/40001/media/mojo/interfaces/video_decoder.mojom ...
4 years, 7 months ago (2016-05-06 23:03:06 UTC) #14
sandersd (OOO until July 31)
dcheng@: Please security review mojom and type converter changes.
4 years, 7 months ago (2016-05-06 23:14:25 UTC) #16
xhwang
LGTM++
4 years, 7 months ago (2016-05-06 23:19:35 UTC) #17
sandersd (OOO until July 31)
On 2016/05/06 23:14:25, sandersd wrote: > dcheng@: Please security review mojom and type converter changes. ...
4 years, 7 months ago (2016-05-10 17:48:26 UTC) #18
dcheng
https://codereview.chromium.org/1899363002/diff/100001/media/mojo/interfaces/video_decoder.mojom File media/mojo/interfaces/video_decoder.mojom (right): https://codereview.chromium.org/1899363002/diff/100001/media/mojo/interfaces/video_decoder.mojom#newcode27 media/mojo/interfaces/video_decoder.mojom:27: Initialize(VideoDecoderConfig config, bool low_delay) => (bool success); It's a ...
4 years, 7 months ago (2016-05-11 07:37:45 UTC) #20
xhwang
comments only https://codereview.chromium.org/1899363002/diff/100001/media/mojo/services/mojo_video_decoder.cc File media/mojo/services/mojo_video_decoder.cc (right): https://codereview.chromium.org/1899363002/diff/100001/media/mojo/services/mojo_video_decoder.cc#newcode59 media/mojo/services/mojo_video_decoder.cc:59: base::Bind(&MojoVideoDecoder::OnInitializeDone, base::Unretained(this))); On 2016/05/11 07:37:45, dcheng wrote: ...
4 years, 7 months ago (2016-05-11 16:13:57 UTC) #21
dcheng
https://codereview.chromium.org/1899363002/diff/100001/media/mojo/services/mojo_video_decoder.cc File media/mojo/services/mojo_video_decoder.cc (right): https://codereview.chromium.org/1899363002/diff/100001/media/mojo/services/mojo_video_decoder.cc#newcode59 media/mojo/services/mojo_video_decoder.cc:59: base::Bind(&MojoVideoDecoder::OnInitializeDone, base::Unretained(this))); On 2016/05/11 at 16:13:57, xhwang wrote: > ...
4 years, 7 months ago (2016-05-11 17:02:50 UTC) #22
xhwang
https://codereview.chromium.org/1899363002/diff/100001/media/mojo/services/mojo_video_decoder.cc File media/mojo/services/mojo_video_decoder.cc (right): https://codereview.chromium.org/1899363002/diff/100001/media/mojo/services/mojo_video_decoder.cc#newcode59 media/mojo/services/mojo_video_decoder.cc:59: base::Bind(&MojoVideoDecoder::OnInitializeDone, base::Unretained(this))); On 2016/05/11 17:02:50, dcheng wrote: > On ...
4 years, 7 months ago (2016-05-11 17:14:58 UTC) #23
sandersd (OOO until July 31)
https://codereview.chromium.org/1899363002/diff/100001/media/mojo/interfaces/video_decoder.mojom File media/mojo/interfaces/video_decoder.mojom (right): https://codereview.chromium.org/1899363002/diff/100001/media/mojo/interfaces/video_decoder.mojom#newcode27 media/mojo/interfaces/video_decoder.mojom:27: Initialize(VideoDecoderConfig config, bool low_delay) => (bool success); On 2016/05/11 ...
4 years, 7 months ago (2016-05-11 18:20:18 UTC) #24
dcheng
(I'll reply to the rest of the comments later) https://codereview.chromium.org/1899363002/diff/100001/media/mojo/services/mojo_video_decoder_service.cc File media/mojo/services/mojo_video_decoder_service.cc (right): https://codereview.chromium.org/1899363002/diff/100001/media/mojo/services/mojo_video_decoder_service.cc#newcode88 media/mojo/services/mojo_video_decoder_service.cc:88: ...
4 years, 7 months ago (2016-05-11 18:26:24 UTC) #25
dcheng
https://codereview.chromium.org/1899363002/diff/100001/media/mojo/interfaces/video_decoder.mojom File media/mojo/interfaces/video_decoder.mojom (right): https://codereview.chromium.org/1899363002/diff/100001/media/mojo/interfaces/video_decoder.mojom#newcode27 media/mojo/interfaces/video_decoder.mojom:27: Initialize(VideoDecoderConfig config, bool low_delay) => (bool success); On 2016/05/11 ...
4 years, 7 months ago (2016-05-11 22:15:06 UTC) #26
sandersd (OOO until July 31)
https://codereview.chromium.org/1899363002/diff/100001/media/mojo/services/mojo_video_decoder_service.cc File media/mojo/services/mojo_video_decoder_service.cc (right): https://codereview.chromium.org/1899363002/diff/100001/media/mojo/services/mojo_video_decoder_service.cc#newcode88 media/mojo/services/mojo_video_decoder_service.cc:88: buffer.To<scoped_refptr<DecoderBuffer>>()); On 2016/05/11 18:26:24, dcheng wrote: > On 2016/05/11 ...
4 years, 7 months ago (2016-05-11 22:49:42 UTC) #27
sandersd (OOO until July 31)
Sorry I missed your comments in the earlier PS! https://codereview.chromium.org/1899363002/diff/100001/media/mojo/interfaces/video_decoder.mojom File media/mojo/interfaces/video_decoder.mojom (right): https://codereview.chromium.org/1899363002/diff/100001/media/mojo/interfaces/video_decoder.mojom#newcode27 media/mojo/interfaces/video_decoder.mojom:27: ...
4 years, 7 months ago (2016-05-11 23:00:50 UTC) #28
sandersd (OOO until July 31)
https://codereview.chromium.org/1899363002/diff/100001/media/mojo/services/mojo_video_decoder.cc File media/mojo/services/mojo_video_decoder.cc (right): https://codereview.chromium.org/1899363002/diff/100001/media/mojo/services/mojo_video_decoder.cc#newcode84 media/mojo/services/mojo_video_decoder.cc:84: uint32_t data_size = base::checked_cast<uint32_t>(buffer->data_size()); On 2016/05/11 17:02:50, dcheng wrote: ...
4 years, 7 months ago (2016-05-12 18:10:36 UTC) #29
dcheng
On 2016/05/12 at 18:10:36, sandersd wrote: > https://codereview.chromium.org/1899363002/diff/100001/media/mojo/services/mojo_video_decoder.cc > File media/mojo/services/mojo_video_decoder.cc (right): > > https://codereview.chromium.org/1899363002/diff/100001/media/mojo/services/mojo_video_decoder.cc#newcode84 ...
4 years, 7 months ago (2016-05-17 06:32:29 UTC) #30
sandersd (OOO until July 31)
https://codereview.chromium.org/1899363002/diff/100001/media/mojo/interfaces/video_decoder.mojom File media/mojo/interfaces/video_decoder.mojom (right): https://codereview.chromium.org/1899363002/diff/100001/media/mojo/interfaces/video_decoder.mojom#newcode27 media/mojo/interfaces/video_decoder.mojom:27: Initialize(VideoDecoderConfig config, bool low_delay) => (bool success); On 2016/05/11 ...
4 years, 7 months ago (2016-05-17 23:05:00 UTC) #31
xhwang
https://codereview.chromium.org/1899363002/diff/100001/media/mojo/interfaces/video_decoder.mojom File media/mojo/interfaces/video_decoder.mojom (right): https://codereview.chromium.org/1899363002/diff/100001/media/mojo/interfaces/video_decoder.mojom#newcode27 media/mojo/interfaces/video_decoder.mojom:27: Initialize(VideoDecoderConfig config, bool low_delay) => (bool success); On 2016/05/17 ...
4 years, 7 months ago (2016-05-17 23:15:38 UTC) #32
Tima Vaisburd
https://codereview.chromium.org/1899363002/diff/200001/media/mojo/services/mojo_audio_decoder_service.cc File media/mojo/services/mojo_audio_decoder_service.cc (right): https://codereview.chromium.org/1899363002/diff/200001/media/mojo/services/mojo_audio_decoder_service.cc#newcode156 media/mojo/services/mojo_audio_decoder_service.cc:156: if (data_size != media_buffer->data_size()) Drive-by: how can they be ...
4 years, 7 months ago (2016-05-18 00:32:16 UTC) #34
sandersd (OOO until July 31)
https://codereview.chromium.org/1899363002/diff/200001/media/mojo/services/mojo_audio_decoder_service.cc File media/mojo/services/mojo_audio_decoder_service.cc (right): https://codereview.chromium.org/1899363002/diff/200001/media/mojo/services/mojo_audio_decoder_service.cc#newcode156 media/mojo/services/mojo_audio_decoder_service.cc:156: if (data_size != media_buffer->data_size()) On 2016/05/18 00:32:16, Tima Vaisburd ...
4 years, 7 months ago (2016-05-18 00:49:29 UTC) #35
sandersd (OOO until July 31)
https://codereview.chromium.org/1899363002/diff/200001/media/mojo/services/mojo_audio_decoder_service.cc File media/mojo/services/mojo_audio_decoder_service.cc (right): https://codereview.chromium.org/1899363002/diff/200001/media/mojo/services/mojo_audio_decoder_service.cc#newcode156 media/mojo/services/mojo_audio_decoder_service.cc:156: if (data_size != media_buffer->data_size()) On 2016/05/18 00:49:29, sandersd wrote: ...
4 years, 7 months ago (2016-05-18 00:50:42 UTC) #36
Tima Vaisburd
On 2016/05/18 00:50:42, sandersd wrote: > https://codereview.chromium.org/1899363002/diff/200001/media/mojo/services/mojo_audio_decoder_service.cc > File media/mojo/services/mojo_audio_decoder_service.cc (right): > > https://codereview.chromium.org/1899363002/diff/200001/media/mojo/services/mojo_audio_decoder_service.cc#newcode156 > ...
4 years, 7 months ago (2016-05-18 01:08:13 UTC) #37
sandersd (OOO until July 31)
On 2016/05/18 at 01:08:13, timav wrote: > On 2016/05/18 00:50:42, sandersd wrote: > > https://codereview.chromium.org/1899363002/diff/200001/media/mojo/services/mojo_audio_decoder_service.cc ...
4 years, 7 months ago (2016-05-18 18:16:46 UTC) #38
sandersd (OOO until July 31)
On 2016/05/18 18:16:46, sandersd wrote: > On 2016/05/18 at 01:08:13, timav wrote: > > On ...
4 years, 7 months ago (2016-05-19 23:21:36 UTC) #39
dcheng
Looking good, just some minor comments. As discussed, we'll reorganize the directory structure in a ...
4 years, 7 months ago (2016-05-20 21:18:22 UTC) #40
sandersd (OOO until July 31)
https://codereview.chromium.org/1899363002/diff/200001/media/mojo/common/media_type_converters.cc File media/mojo/common/media_type_converters.cc (left): https://codereview.chromium.org/1899363002/diff/200001/media/mojo/common/media_type_converters.cc#oldcode431 media/mojo/common/media_type_converters.cc:431: base::checked_cast<uint32_t>(input->side_data_size()); On 2016/05/20 21:18:22, dcheng wrote: > Can we ...
4 years, 7 months ago (2016-05-20 22:27:14 UTC) #41
dcheng
lgtm with a nit https://codereview.chromium.org/1899363002/diff/200001/media/mojo/common/media_type_converters.cc File media/mojo/common/media_type_converters.cc (left): https://codereview.chromium.org/1899363002/diff/200001/media/mojo/common/media_type_converters.cc#oldcode431 media/mojo/common/media_type_converters.cc:431: base::checked_cast<uint32_t>(input->side_data_size()); On 2016/05/20 at 22:27:14, ...
4 years, 7 months ago (2016-05-20 22:52:59 UTC) #42
sandersd (OOO until July 31)
https://codereview.chromium.org/1899363002/diff/220001/media/mojo/services/mojo_video_decoder_service.cc File media/mojo/services/mojo_video_decoder_service.cc (right): https://codereview.chromium.org/1899363002/diff/220001/media/mojo/services/mojo_video_decoder_service.cc#newcode110 media/mojo/services/mojo_video_decoder_service.cc:110: CHECK_EQ(data_size, media_buffer->data_size()); On 2016/05/20 22:52:59, dcheng wrote: > Nit: ...
4 years, 7 months ago (2016-05-20 23:42:13 UTC) #43
dcheng
https://codereview.chromium.org/1899363002/diff/220001/media/mojo/services/mojo_video_decoder_service.cc File media/mojo/services/mojo_video_decoder_service.cc (right): https://codereview.chromium.org/1899363002/diff/220001/media/mojo/services/mojo_video_decoder_service.cc#newcode110 media/mojo/services/mojo_video_decoder_service.cc:110: CHECK_EQ(data_size, media_buffer->data_size()); On 2016/05/20 at 23:42:12, sandersd wrote: > ...
4 years, 7 months ago (2016-05-20 23:48:14 UTC) #44
sandersd (OOO until July 31)
https://codereview.chromium.org/1899363002/diff/220001/media/mojo/services/mojo_video_decoder_service.cc File media/mojo/services/mojo_video_decoder_service.cc (right): https://codereview.chromium.org/1899363002/diff/220001/media/mojo/services/mojo_video_decoder_service.cc#newcode110 media/mojo/services/mojo_video_decoder_service.cc:110: CHECK_EQ(data_size, media_buffer->data_size()); On 2016/05/20 23:48:14, dcheng wrote: > On ...
4 years, 7 months ago (2016-05-20 23:56:14 UTC) #45
sandersd (OOO until July 31)
jochen@chromium.org: Please review changes in content/renderer/
4 years, 7 months ago (2016-05-20 23:57:33 UTC) #47
sandersd (OOO until July 31)
=> sievers@ for content/ review, as jochen is OOO.
4 years, 7 months ago (2016-05-23 21:48:39 UTC) #49
sandersd (OOO until July 31)
sievers@: ping.
4 years, 7 months ago (2016-05-24 17:46:22 UTC) #50
sandersd (OOO until July 31)
Looks like sievers is gone now too. piman@: Please review changes in content/
4 years, 7 months ago (2016-05-25 00:11:41 UTC) #52
piman
LGTM for content/
4 years, 7 months ago (2016-05-25 00:18:58 UTC) #53
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899363002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899363002/240001
4 years, 7 months ago (2016-05-25 00:23:01 UTC) #56
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/227563)
4 years, 7 months ago (2016-05-25 01:52:37 UTC) #58
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899363002/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899363002/260001
4 years, 7 months ago (2016-05-25 18:14:29 UTC) #61
commit-bot: I haz the power
Committed patchset #14 (id:260001)
4 years, 7 months ago (2016-05-25 20:06:49 UTC) #63
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 20:08:42 UTC) #65
Message was sent while issue was closed.
Patchset 14 (id:??) landed as
https://crrev.com/e78f9cb7d7bb4709436482572eb6fcb9a795e3b1
Cr-Commit-Position: refs/heads/master@{#395971}

Powered by Google App Engine
This is Rietveld 408576698