Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1277)

Issue 189933002: Get rid of allowCookies() usage. (Closed)

Created:
6 years, 9 months ago by Hajime Morrita
Modified:
6 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Get rid of allowCookies() usage. It represents the same state of allowStoredCredentials() thus removed to kill the redundancy. This is a part of a two sided change. The API will be removed once this has landed. BUG=none TEST=none R=avi@chromium.org, darin@chromium.org, jochen@chormium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255999

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/child/web_url_loader_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Hajime Morrita
PTAL? This single line CL is a part of two sided change. Another half is ...
6 years, 9 months ago (2014-03-07 03:12:08 UTC) #1
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 9 months ago (2014-03-07 03:12:18 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 03:16:02 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 9 months ago (2014-03-07 03:16:03 UTC) #4
Hajime Morrita
@Darin, could you take a look? It's just a one line change and I already ...
6 years, 9 months ago (2014-03-07 21:22:10 UTC) #5
Hajime Morrita
Darin, or anyone, could you rubberstamp this please? This is a tiny change that is ...
6 years, 9 months ago (2014-03-10 17:30:18 UTC) #6
Avi (use Gerrit)
LGTM
6 years, 9 months ago (2014-03-10 17:35:38 UTC) #7
Hajime Morrita
On 2014/03/10 17:35:38, Avi wrote: > LGTM Thanks!
6 years, 9 months ago (2014-03-10 17:37:06 UTC) #8
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 9 months ago (2014-03-10 17:37:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/189933002/1
6 years, 9 months ago (2014-03-10 18:04:02 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-10 18:24:31 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-10 18:24:33 UTC) #12
Hajime Morrita
6 years, 9 months ago (2014-03-10 18:47:42 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 manually as r255999 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698