Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: services/shell/public/cpp/shell_connection.h

Issue 1899323002: Add mash shelf application id support. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address simpler comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/shell/public/cpp/lib/shell_connection.cc ('k') | ui/views/mus/platform_test_helper_mus.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/shell/public/cpp/shell_connection.h
diff --git a/services/shell/public/cpp/shell_connection.h b/services/shell/public/cpp/shell_connection.h
index 84aae0daae91e748a1feb3483809eaf28cd3abde..7f8928bb76514dd75805ad91b6f12f8954df05e7 100644
--- a/services/shell/public/cpp/shell_connection.h
+++ b/services/shell/public/cpp/shell_connection.h
@@ -54,6 +54,7 @@ class ShellConnection : public mojom::ShellClient {
~ShellConnection() override;
Connector* connector() { return connector_.get(); }
+ const Identity& identity() { return identity_; }
// TODO(rockot): Remove this. http://crbug.com/594852.
void set_initialize_handler(const base::Closure& callback);
@@ -66,37 +67,38 @@ class ShellConnection : public mojom::ShellClient {
connection_lost_closure_ = closure;
}
-private:
- // mojom::ShellClient:
- void Initialize(mojom::IdentityPtr identity,
- uint32_t id,
- const InitializeCallback& callback) override;
- void AcceptConnection(mojom::IdentityPtr source,
- uint32_t source_id,
- mojom::InterfaceProviderRequest remote_interfaces,
- mojom::InterfaceProviderPtr local_interfaces,
- mojom::CapabilityRequestPtr allowed_capabilities,
- const mojo::String& name) override;
+ private:
+ // mojom::ShellClient:
+ void Initialize(mojom::IdentityPtr identity,
+ uint32_t id,
+ const InitializeCallback& callback) override;
+ void AcceptConnection(mojom::IdentityPtr source,
+ uint32_t source_id,
+ mojom::InterfaceProviderRequest remote_interfaces,
+ mojom::InterfaceProviderPtr local_interfaces,
+ mojom::CapabilityRequestPtr allowed_capabilities,
+ const mojo::String& name) override;
- void OnConnectionError();
+ void OnConnectionError();
- // A callback called when Initialize() is run.
- base::Closure initialize_handler_;
+ // A callback called when Initialize() is run.
+ base::Closure initialize_handler_;
- // We track the lifetime of incoming connection registries as it more
- // convenient for the client.
- ScopedVector<Connection> incoming_connections_;
+ // We track the lifetime of incoming connection registries as it more
+ // convenient for the client.
+ ScopedVector<Connection> incoming_connections_;
- // A pending Connector request which will eventually be passed to the shell.
- mojom::ConnectorRequest pending_connector_request_;
+ // A pending Connector request which will eventually be passed to the shell.
+ mojom::ConnectorRequest pending_connector_request_;
- shell::ShellClient* client_;
- mojo::Binding<mojom::ShellClient> binding_;
- std::unique_ptr<Connector> connector_;
+ shell::ShellClient* client_;
+ mojo::Binding<mojom::ShellClient> binding_;
+ std::unique_ptr<Connector> connector_;
+ shell::Identity identity_;
- base::Closure connection_lost_closure_;
+ base::Closure connection_lost_closure_;
- DISALLOW_COPY_AND_ASSIGN(ShellConnection);
+ DISALLOW_COPY_AND_ASSIGN(ShellConnection);
};
} // namespace shell
« no previous file with comments | « services/shell/public/cpp/lib/shell_connection.cc ('k') | ui/views/mus/platform_test_helper_mus.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698