Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Unified Diff: mash/shelf/public/interfaces/shelf.mojom

Issue 1899323002: Add mash shelf application id support. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address simpler comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mash/screenlock/screenlock.cc ('k') | mash/task_viewer/task_viewer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mash/shelf/public/interfaces/shelf.mojom
diff --git a/mash/shelf/public/interfaces/shelf.mojom b/mash/shelf/public/interfaces/shelf.mojom
index 3e7887b271606d4ad449b5772796f31931ed496b..9b21fb18a216e82a2fda60b0c55c6337dbc45049 100644
--- a/mash/shelf/public/interfaces/shelf.mojom
+++ b/mash/shelf/public/interfaces/shelf.mojom
@@ -16,8 +16,8 @@ interface ShelfController {
SetAlignment(Alignment alignment);
SetAutoHideBehavior(AutoHideBehavior auto_hide);
- AddItem(ShelfItem item, associated ShelfItemDelegate delegate);
- RemoveItem(string id);
+ PinItem(ShelfItem item, associated ShelfItemDelegate delegate);
+ UnpinItem(string app_id);
};
// ShelfObserver is notified on shelf changes; used to persist profile settings.
@@ -55,11 +55,11 @@ struct ContextMenuItem {
// ShelfItem contains the basic fields needed to pin shortcut items.
struct ShelfItem {
- // An id, used to correlate windows and shortcuts (eg. 'exe:chrome').
- string id;
+ // An app id, used to correlate windows and shortcuts (eg. 'mojo:foo').
+ string app_id;
- // A title, used for tooltips, etc. (eg. 'Chrome').
- string title;
+ // A app title, used for tooltips, etc. (eg. 'Foo Application').
+ string app_title;
// An icon image Bitmap, shown on the shelf.
skia.mojom.Bitmap image;
« no previous file with comments | « mash/screenlock/screenlock.cc ('k') | mash/task_viewer/task_viewer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698