Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1899303002: Avoid using MediaCodecList from Renderer process (Closed)

Created:
4 years, 8 months ago by qinmin
Modified:
4 years, 8 months ago
Reviewers:
Tima Vaisburd
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, avayvod+watch_chromium.org, mlamouri+watch-media_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid using MediaCodecList from Renderer process Renderer process cannot access the MediaServer process, and it cannot access MediaCodecList. Do not use getDefaultCodecName() in MediaCodecUtil.isDecoderSupportedForDevice, instead,switch to Build.HARDWARE to check if the device is MTK. We might hit some corner cases, but still better than page not loading. BUG=604602, 597836 Committed: https://crrev.com/717ee19a82bde7395ea138843b09a826b5681463 Cr-Commit-Position: refs/heads/master@{#388304}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M media/base/android/java/src/org/chromium/media/MediaCodecUtil.java View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
qinmin
PTAL
4 years, 8 months ago (2016-04-19 19:28:55 UTC) #2
Tima Vaisburd
lgtm
4 years, 8 months ago (2016-04-19 19:35:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899303002/1
4 years, 8 months ago (2016-04-19 19:36:27 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 20:50:33 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:16:11 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/717ee19a82bde7395ea138843b09a826b5681463
Cr-Commit-Position: refs/heads/master@{#388304}

Powered by Google App Engine
This is Rietveld 408576698