Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: test/cctest/test-api.cc

Issue 1899283003: Allow for creating Private API symbols that have a number as an ID (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects-inl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 25008 matching lines...) Expand 10 before | Expand all | Expand 10 after
25019 25019
25020 v8::Local<v8::Value> is_frozen = CompileRun("Object.isFrozen(o)"); 25020 v8::Local<v8::Value> is_frozen = CompileRun("Object.isFrozen(o)");
25021 CHECK(!is_frozen->BooleanValue(context.local()).FromJust()); 25021 CHECK(!is_frozen->BooleanValue(context.local()).FromJust());
25022 25022
25023 CHECK(obj->SetIntegrityLevel(context.local(), v8::IntegrityLevel::kFrozen) 25023 CHECK(obj->SetIntegrityLevel(context.local(), v8::IntegrityLevel::kFrozen)
25024 .FromJust()); 25024 .FromJust());
25025 25025
25026 is_frozen = CompileRun("Object.isFrozen(o)"); 25026 is_frozen = CompileRun("Object.isFrozen(o)");
25027 CHECK(is_frozen->BooleanValue(context.local()).FromJust()); 25027 CHECK(is_frozen->BooleanValue(context.local()).FromJust());
25028 } 25028 }
25029
25030 TEST(PrivateForApiIsNumber) {
25031 LocalContext context;
25032 v8::Isolate* isolate = CcTest::isolate();
25033 v8::HandleScope scope(isolate);
25034
25035 // Shouldn't crash.
25036 v8::Private::ForApi(isolate, v8_str("42"));
25037 }
OLDNEW
« no previous file with comments | « src/objects-inl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698