Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1899283003: Allow for creating Private API symbols that have a number as an ID (Closed)

Created:
4 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Allow for creating Private API symbols that have a number as an ID BUG=v8:4933 R=verwaest@chromium.org LOG=n Committed: https://crrev.com/2cfac65eacd308ab83b8750b159d321f380b6cf2 Cr-Commit-Position: refs/heads/master@{#35692}

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Patch Set 4 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +11 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jochen (gone - plz use gerrit)
4 years, 8 months ago (2016-04-20 15:28:09 UTC) #1
jochen (gone - plz use gerrit)
ptal
4 years, 8 months ago (2016-04-20 15:32:13 UTC) #2
Toon Verwaest
lgtm
4 years, 8 months ago (2016-04-21 09:34:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899283003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899283003/60001
4 years, 8 months ago (2016-04-21 09:47:23 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-21 09:49:04 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:14:20 UTC) #8
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/2cfac65eacd308ab83b8750b159d321f380b6cf2
Cr-Commit-Position: refs/heads/master@{#35692}

Powered by Google App Engine
This is Rietveld 408576698