Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Unified Diff: runtime/vm/timeline.cc

Issue 1899273002: Fix --startup-timeline (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/timeline.cc
diff --git a/runtime/vm/timeline.cc b/runtime/vm/timeline.cc
index 1e8c3a474d1a83d7cab77111a9ffed37a0595f10..0adf8410e20dfaa2a6d61b9c5d1b34bc05a2fde3 100644
--- a/runtime/vm/timeline.cc
+++ b/runtime/vm/timeline.cc
@@ -85,17 +85,21 @@ static TimelineEventRecorder* CreateTimelineRecorder() {
const bool use_endless_recorder =
(FLAG_timeline_dir != NULL) || FLAG_timing || FLAG_complete_timeline;
+ const bool use_startup_recorder = FLAG_startup_timeline;
+
const char* flag = FLAG_timeline_recorder;
if (use_endless_recorder || (flag != NULL)) {
- if (use_endless_recorder || strcmp("endless", flag) == 0) {
+ if (use_endless_recorder || (strcmp("endless", flag) == 0)) {
if (FLAG_trace_timeline) {
THR_Print("Using the endless timeline recorder.\n");
}
return new TimelineEventEndlessRecorder();
}
+ }
- if (strcmp("startup", flag) == 0) {
+ if (use_startup_recorder || (flag != NULL)) {
+ if (use_startup_recorder || (strcmp("startup", flag) == 0)) {
if (FLAG_trace_timeline) {
THR_Print("Using the startup recorder.\n");
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698