Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 189923003: Fix a typo in webview_custom_bindings.js (Closed)

Created:
6 years, 9 months ago by lazyboy
Modified:
6 years, 9 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix a typo in webview_custom_bindings.js BUG=140315 Test=None, this bindings is not exposed yet. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255840

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/renderer/resources/extensions/webview_custom_bindings.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 34 (0 generated)
lazyboy
6 years, 9 months ago (2014-03-07 06:55:23 UTC) #1
Yoyo Zhou
LGTM
6 years, 9 months ago (2014-03-07 18:52:43 UTC) #2
lazyboy
The CQ bit was checked by lazyboy@chromium.org
6 years, 9 months ago (2014-03-07 19:33:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/189923003/1
6 years, 9 months ago (2014-03-07 19:34:18 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 19:54:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 9 months ago (2014-03-07 19:54:46 UTC) #6
lazyboy
The CQ bit was checked by lazyboy@chromium.org
6 years, 9 months ago (2014-03-07 19:55:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/189923003/1
6 years, 9 months ago (2014-03-07 20:28:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/189923003/1
6 years, 9 months ago (2014-03-08 10:54:59 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 13:39:29 UTC) #10
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234297
6 years, 9 months ago (2014-03-08 13:39:29 UTC) #11
lazyboy
The CQ bit was checked by lazyboy@chromium.org
6 years, 9 months ago (2014-03-08 13:50:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/189923003/1
6 years, 9 months ago (2014-03-08 13:53:08 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 14:41:12 UTC) #14
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234386
6 years, 9 months ago (2014-03-08 14:41:13 UTC) #15
lazyboy
The CQ bit was checked by lazyboy@chromium.org
6 years, 9 months ago (2014-03-08 15:18:10 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/189923003/1
6 years, 9 months ago (2014-03-08 15:18:24 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 15:55:07 UTC) #18
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234428
6 years, 9 months ago (2014-03-08 15:55:08 UTC) #19
lazyboy
The CQ bit was checked by lazyboy@chromium.org
6 years, 9 months ago (2014-03-08 17:18:12 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/189923003/1
6 years, 9 months ago (2014-03-08 17:18:27 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 17:54:36 UTC) #22
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234502
6 years, 9 months ago (2014-03-08 17:54:37 UTC) #23
lazyboy
The CQ bit was checked by lazyboy@chromium.org
6 years, 9 months ago (2014-03-08 18:56:54 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/189923003/1
6 years, 9 months ago (2014-03-08 18:57:03 UTC) #25
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 19:47:50 UTC) #26
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234538
6 years, 9 months ago (2014-03-08 19:47:50 UTC) #27
lazyboy
The CQ bit was checked by lazyboy@chromium.org
6 years, 9 months ago (2014-03-08 19:54:25 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/189923003/1
6 years, 9 months ago (2014-03-08 19:54:36 UTC) #29
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 21:38:07 UTC) #30
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234570
6 years, 9 months ago (2014-03-08 21:38:08 UTC) #31
lazyboy
The CQ bit was checked by lazyboy@chromium.org
6 years, 9 months ago (2014-03-09 08:50:18 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/189923003/1
6 years, 9 months ago (2014-03-09 08:50:30 UTC) #33
commit-bot: I haz the power
6 years, 9 months ago (2014-03-09 09:24:17 UTC) #34
Message was sent while issue was closed. 
Change committed as 255840

Powered by Google App Engine
This is Rietveld 408576698