scripts/slave/recipe_modules/bisect_tester/perf_test.py - Issue 1899193003: Set CHROMIUM_OUTPUT_DIR when running the android-chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/bisect_tester/perf_test.py

Issue 1899193003: Set CHROMIUM_OUTPUT_DIR when running the android-chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_fyi_perf_bisect.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/bisect_tester/perf_test.py

diff --git a/scripts/slave/recipe_modules/bisect_tester/perf_test.py b/scripts/slave/recipe_modules/bisect_tester/perf_test.py

index 5cea5e7bd0915a962d2c811992a547dfdbb745dc..3042d6fe0dac402e69c8fc6d95175d81b8c88758 100644

--- a/scripts/slave/recipe_modules/bisect_tester/perf_test.py

+++ b/scripts/slave/recipe_modules/bisect_tester/perf_test.py

@@ -191,12 +191,20 @@ def _run_command(api, command, step_name):

command_parts = command.split()

stdout = api.m.raw_io.output()

stderr = api.m.raw_io.output()

+ # TODO(prasadv): Remove this once bisect runs are no longer running

+ # against revisions from February 2016 or earlier.

+ kwargs = {}

+ if 'android-chrome' in command: # pragma: no cover

+ kwargs['env'] = {'CHROMIUM_OUTPUT_DIR': api.m.chromium.output_dir}

try:

step_result = api.m.step(

step_name,

command_parts,

stdout=stdout,

- stderr=stderr)

+ stderr=stderr,

+ **kwargs)

step_result.presentation.logs['Captured Output'] = (

step_result.stdout or '').splitlines()

except api.m.step.StepFailure as sf: