Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(46)

Issue 1899133010: Fix two checked mode bugs introduced by 0.13.0. (Closed)

Created:
4 years, 6 months ago by Bob Nystrom
Modified:
4 years, 6 months ago
Reviewers:
terry
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/csslib.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix two checked mode bugs introduced by 0.13.0. Covariant generics :( R=terry@google.com Committed: https://github.com/dart-lang/csslib/commit/959aaed3b215c739952ce4abf536d7bf4b84634d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/tree.dart View 1 chunk +1 line, -1 line 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
4 years, 6 months ago (2016-04-21 17:47:11 UTC) #2
terry
lgtm
4 years, 6 months ago (2016-04-21 18:17:28 UTC) #3
Bob Nystrom
4 years, 6 months ago (2016-04-21 18:18:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
959aaed3b215c739952ce4abf536d7bf4b84634d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698