Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 189913023: Use a per-isolate cache for the date object JS bits (Closed)

Created:
6 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 9 months ago
Reviewers:
dcarney, ulan
CC:
v8-dev
Visibility:
Public.

Description

Use a per-isolate cache for the date object JS bits The old per-context cache made it difficult for the embedder to notify v8 of date/time configuration changes. The embedder had to enter all contexts for the isolate and notify v8 for each context. With the new per-isolate cache, the embedder only needs to notify v8 once per isolate. BUG=348856 LOG=y R=dcarney@chromium.org, ulan@chromium.org TEST=cctest/test-date Committed: https://code.google.com/p/v8/source/detail?r=19784

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -23 lines) Patch
M src/api.cc View 1 1 chunk +9 lines, -22 lines 0 comments Download
M src/date.js View 1 3 chunks +15 lines, -1 line 0 comments Download
M src/global-handles.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 1 chunk +22 lines, -0 lines 0 comments Download
M test/cctest/test-date.cc View 1 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
6 years, 9 months ago (2014-03-10 22:52:58 UTC) #1
dcarney
lgtm
6 years, 9 months ago (2014-03-11 07:37:31 UTC) #2
dcarney
lgtm, again
6 years, 9 months ago (2014-03-11 08:17:18 UTC) #3
jochen (gone - plz use gerrit)
6 years, 9 months ago (2014-03-11 09:04:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r19784 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698