Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 189913017: Avoid duplicate null check in ReplaceSelectionCommand::pastLastLeaf() (Closed)

Created:
6 years, 9 months ago by Inactive
Modified:
6 years, 9 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Avoid duplicate null check in ReplaceSelectionCommand::pastLastLeaf() Avoid duplicate null check in ReplaceSelectionCommand::pastLastLeaf() by calling m_lastNodeInserted->lastDescendant() directly instead of lastLeafInserted(). This also makes it clearer by we are checking that m_lastNodeInserted is not null as it is now explicitly use right after. This avoid avoids dereferencing a pointer as we now get a reference directly. R=adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168848

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/editing/ReplaceSelectionCommand.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
Small follow-up clean up.
6 years, 9 months ago (2014-03-10 17:32:18 UTC) #1
adamk
lgtm
6 years, 9 months ago (2014-03-10 18:03:46 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 9 months ago (2014-03-10 18:12:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/189913017/1
6 years, 9 months ago (2014-03-10 18:13:32 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-10 18:33:22 UTC) #5
Message was sent while issue was closed.
Change committed as 168848

Powered by Google App Engine
This is Rietveld 408576698