Issue 189913014: Bug fix: Combobox: Focus on clicking mouse button

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 189913014: Bug fix: Combobox: Focus on clicking mouse button (Closed)

Created:
6 years, 9 months ago by hajimehoshi

Modified:
6 years, 9 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Bug fix: Combobox: Focus on clicking mouse button This CL fixes the regression that Combobox doesn't get focused when clicking a right button of a mouse. Before introducing TransparentButton, Combobox can get focus by itself on the mouse button events, but now, TranparentButton robs the combobox of the events. This CL has TransparentButton::OnMousePressed help the combobox with focusing it. BUG=350811 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256016

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	ui/views/controls/combobox/combobox.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/189913014/1

6 years, 9 months ago (2014-03-10 14:32:40 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/189913014/1

6 years, 9 months ago (2014-03-10 15:58:46 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/189913014/1

6 years, 9 months ago (2014-03-10 17:42:18 UTC) #6

Message was sent while issue was closed.

Change committed as 256016

Expand Messages | Collapse Messages