Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 189913012: Merge SVGColor into SVGPaint (Closed)

Created:
6 years, 9 months ago by rwlbuis
Modified:
6 years, 9 months ago
CC:
blink-reviews, shans, fs, apavlov+blink_chromium.org, kouhei+svg_chromium.org, dino_apple.com, rune+blink, krit, alancutter (OOO until 2018), dglazkov+blink, dstockwell, Timothy Loh, f(malita), pdr., rwlbuis, Eric Willigers, rjwright, gyuyoung.kim_webkit.org, darktears, Mike Lawther (Google), ed+blinkwatch_opera.com, Steve Block, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Merge SVGColor into SVGPaint Merge SVGColor into SVGPaint and thus remove SVGColor. There is no need for this class anymore in SVG2. Instead we use CSSPrimitiveValue and add color handling to SVGPaint. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168837

Patch Set 1 #

Patch Set 2 : Fix transition test #

Patch Set 3 : Fix system color test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -283 lines) Patch
M Source/core/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSValue.h View 3 chunks +1 line, -3 lines 0 comments Download
M Source/core/css/CSSValue.cpp View 7 chunks +0 lines, -16 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 2 chunks +12 lines, -17 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 2 5 chunks +18 lines, -12 lines 0 comments Download
M Source/core/svg/SVGAnimatedColor.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGAnimatedNewPropertyAnimator.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
D Source/core/svg/SVGColor.h View 1 chunk +0 lines, -104 lines 0 comments Download
D Source/core/svg/SVGColor.cpp View 1 chunk +0 lines, -88 lines 0 comments Download
M Source/core/svg/SVGFEDiffuseLightingElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGPaint.h View 6 chunks +14 lines, -6 lines 0 comments Download
M Source/core/svg/SVGPaint.cpp View 1 4 chunks +20 lines, -31 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
rwlbuis
Pretty straightforward patch in the end, with some subtleties that are now fixed.
6 years, 9 months ago (2014-03-10 01:54:44 UTC) #1
rwlbuis
Adding some more reviewers since pdr may be afk until tuesday.
6 years, 9 months ago (2014-03-10 02:05:38 UTC) #2
kouhei (in TOK)
non-owner lgtm
6 years, 9 months ago (2014-03-10 02:10:33 UTC) #3
Stephen Chennney
Owner LGTM. Thanks Kouhei for the review.
6 years, 9 months ago (2014-03-10 14:31:05 UTC) #4
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 9 months ago (2014-03-10 15:03:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/189913012/40001
6 years, 9 months ago (2014-03-10 15:17:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/189913012/40001
6 years, 9 months ago (2014-03-10 15:36:46 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-10 15:59:44 UTC) #8
Message was sent while issue was closed. 
Change committed as 168837

Powered by Google App Engine
This is Rietveld 408576698