Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 189913011: Remove "if (WallpaperManager::Get())" from MultiUserWindowManagerChromeOS::TransitionWallpaper() (Closed)

Created:
6 years, 9 months ago by Thiemo Nagel
Modified:
6 years, 9 months ago
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove "if (WallpaperManager::Get())" from MultiUserWindowManagerChromeOS::TransitionWallpaper() chromeos::WallpaperManager::Get() either returns true or it returns not at all, thus the if(...) can be safely removed. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255989

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc View 1 chunk +12 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Thiemo Nagel
Hi Stefan, could you please look into this? What was the idea of putting "if ...
6 years, 9 months ago (2014-03-09 13:39:09 UTC) #1
Mr4D (OOO till 08-26)
lgtm
6 years, 9 months ago (2014-03-10 14:21:08 UTC) #2
Thiemo Nagel
The CQ bit was checked by tnagel@chromium.org
6 years, 9 months ago (2014-03-10 14:22:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/189913011/1
6 years, 9 months ago (2014-03-10 14:32:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/189913011/1
6 years, 9 months ago (2014-03-10 15:57:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/189913011/1
6 years, 9 months ago (2014-03-10 17:42:04 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-10 18:33:32 UTC) #7
Message was sent while issue was closed.
Change committed as 255989

Powered by Google App Engine
This is Rietveld 408576698