Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1899103002: XFA unused function cleanup (Closed)

Created:
4 years, 8 months ago by dsinclair
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

XFA unused function cleanup This CL removes a series of unused XFA methods. Committed: https://pdfium.googlesource.com/pdfium/+/0582ad18b1e7ab9e404b7f8071a015ec756f5afe

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -302 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M xfa.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffdoc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/include/fxfa_basic.h View 5 chunks +7 lines, -10 lines 0 comments Download
M xfa/fxfa/parser/xfa_basic_data.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_basic_imp.cpp View 8 chunks +7 lines, -41 lines 3 comments Download
D xfa/fxfa/parser/xfa_docdata.h View 1 chunk +0 lines, -16 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_datadescription_imp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_document_datamerger_imp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_document_imp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_document_layout_imp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_document_serialize.h View 1 chunk +7 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_document_serialize.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_layout_appadapter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_layout_itemlayout.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_layout_pagemgr_new.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_locale.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_localemgr.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_localevalue.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_object.h View 1 chunk +0 lines, -12 lines 0 comments Download
M xfa/fxfa/parser/xfa_object_imp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_parser_imp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script.h View 1 chunk +0 lines, -7 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_datawindow.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_eventpseudomodel.h View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_eventpseudomodel.cpp View 2 chunks +0 lines, -7 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_hostpseudomodel.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_imp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_layoutpseudomodel.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_logpseudomodel.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_nodehelper.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_resolveprocessor.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_signaturepseudomodel.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_utils.h View 1 chunk +1 line, -3 lines 0 comments Download
M xfa/fxfa/parser/xfa_utils_imp.cpp View 2 chunks +1 line, -32 lines 0 comments Download
M xfa/fxjse/class.cpp View 2 chunks +0 lines, -29 lines 0 comments Download
M xfa/fxjse/context.cpp View 2 chunks +0 lines, -52 lines 0 comments Download
M xfa/fxjse/include/fxjse.h View 5 chunks +0 lines, -25 lines 0 comments Download
M xfa/fxjse/value.cpp View 6 chunks +0 lines, -39 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dsinclair
PTAL.
4 years, 8 months ago (2016-04-19 02:32:32 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1899103002/diff/1/xfa/fxfa/parser/xfa_basic_imp.cpp File xfa/fxfa/parser/xfa_basic_imp.cpp (right): https://codereview.chromium.org/1899103002/diff/1/xfa/fxfa/parser/xfa_basic_imp.cpp#newcode343 xfa/fxfa/parser/xfa_basic_imp.cpp:343: XFA_SCRIPTHIERARCHY const* scriptIndex = g_XFAScriptIndex + iElementIndex; XFA_SCRIPTHIERARCHY* ...
4 years, 8 months ago (2016-04-19 04:25:51 UTC) #3
dsinclair
https://codereview.chromium.org/1899103002/diff/1/xfa/fxfa/parser/xfa_basic_imp.cpp File xfa/fxfa/parser/xfa_basic_imp.cpp (right): https://codereview.chromium.org/1899103002/diff/1/xfa/fxfa/parser/xfa_basic_imp.cpp#newcode343 xfa/fxfa/parser/xfa_basic_imp.cpp:343: XFA_SCRIPTHIERARCHY const* scriptIndex = g_XFAScriptIndex + iElementIndex; On 2016/04/19 ...
4 years, 8 months ago (2016-04-19 12:53:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899103002/1
4 years, 8 months ago (2016-04-19 12:53:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/0582ad18b1e7ab9e404b7f8071a015ec756f5afe
4 years, 8 months ago (2016-04-19 12:53:45 UTC) #8
Lei Zhang
4 years, 8 months ago (2016-04-19 17:45:20 UTC) #9
Message was sent while issue was closed. 
https://codereview.chromium.org/1899103002/diff/1/xfa/fxfa/parser/xfa_basic_i...
File xfa/fxfa/parser/xfa_basic_imp.cpp (right):

https://codereview.chromium.org/1899103002/diff/1/xfa/fxfa/parser/xfa_basic_i...
xfa/fxfa/parser/xfa_basic_imp.cpp:343: XFA_SCRIPTHIERARCHY const* scriptIndex =
g_XFAScriptIndex + iElementIndex;
On 2016/04/19 12:53:10, dsinclair wrote:
> On 2016/04/19 04:25:51, Lei Zhang wrote:
> > XFA_SCRIPTHIERARCHY* const ?
> 
> Nak.   cannot initialize a variable of type 'XFA_SCRIPTHIERARCHY *const' with
an
> rvalue of type 'const XFA_SCRIPTHIERARCHY *

Oh, umm, const XFA_SCRIPTHIERARCHY* then?

Powered by Google App Engine
This is Rietveld 408576698