Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18991017: Add Stream support to FileReaderLoader. (Closed)

Created:
7 years, 5 months ago by tyoshino (SeeGerritForStatus)
Modified:
7 years, 5 months ago
Reviewers:
kinuko, tkent
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Visibility:
Public.

Description

Add Stream support to FileReaderLoader. To be used directly by Stream (with Promises) or FileReader. BUG=169957 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154111

Patch Set 1 #

Total comments: 2

Patch Set 2 : tkent's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M Source/core/fileapi/FileReaderLoader.h View 1 3 chunks +6 lines, -0 lines 0 comments Download
M Source/core/fileapi/FileReaderLoader.cpp View 1 4 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
tyoshino (SeeGerritForStatus)
7 years, 5 months ago (2013-07-12 06:45:20 UTC) #1
kinuko
lgtm
7 years, 5 months ago (2013-07-12 07:50:38 UTC) #2
tyoshino (SeeGerritForStatus)
+tkent for OWNERS review
7 years, 5 months ago (2013-07-12 08:12:31 UTC) #3
tkent
lgtm https://codereview.chromium.org/18991017/diff/1/Source/core/fileapi/FileReaderLoader.cpp File Source/core/fileapi/FileReaderLoader.cpp (right): https://codereview.chromium.org/18991017/diff/1/Source/core/fileapi/FileReaderLoader.cpp#newcode116 Source/core/fileapi/FileReaderLoader.cpp:116: void FileReaderLoader::start(ScriptExecutionContext* scriptExecutionContext, Stream* stream) nit: We assume ...
7 years, 5 months ago (2013-07-12 09:03:49 UTC) #4
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/18991017/diff/1/Source/core/fileapi/FileReaderLoader.cpp File Source/core/fileapi/FileReaderLoader.cpp (right): https://codereview.chromium.org/18991017/diff/1/Source/core/fileapi/FileReaderLoader.cpp#newcode116 Source/core/fileapi/FileReaderLoader.cpp:116: void FileReaderLoader::start(ScriptExecutionContext* scriptExecutionContext, Stream* stream) On 2013/07/12 09:03:49, tkent ...
7 years, 5 months ago (2013-07-12 11:15:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/18991017/8001
7 years, 5 months ago (2013-07-12 11:15:34 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_python_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=16470
7 years, 5 months ago (2013-07-12 11:35:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/18991017/8001
7 years, 5 months ago (2013-07-12 11:44:21 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_python_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=16478
7 years, 5 months ago (2013-07-12 11:57:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/18991017/8001
7 years, 5 months ago (2013-07-12 11:57:59 UTC) #10
commit-bot: I haz the power
7 years, 5 months ago (2013-07-12 12:51:14 UTC) #11
Message was sent while issue was closed. 
Change committed as 154111

Powered by Google App Engine
This is Rietveld 408576698