Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1899093002: [remoting host] Fix/remove version-reporting in GN builds. (Closed)

Created:
4 years, 8 months ago by Lambros
Modified:
4 years, 8 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[remoting host] Fix/remove version-reporting in GN builds. This fixes remoting_me2me_host --version to report the correct version instead of the literal string 'VERSION'. This also removes the --host-version option from the Python script, since it is no longer used (it was used only by the NPAPI plugin). TEST='out/foo/remoting_me2me_host --version' reports correct version. Committed: https://crrev.com/cf3b9c5368b230baf30a97e2ddfa4529fc1bb0e5 Cr-Commit-Position: refs/heads/master@{#388305}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M remoting/host/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/host/linux/linux_me2me_host.py View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Lambros
4 years, 8 months ago (2016-04-19 01:27:52 UTC) #2
Sergey Ulanov
lgtm
4 years, 8 months ago (2016-04-19 19:36:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899093002/1
4 years, 8 months ago (2016-04-19 20:04:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 21:00:00 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:16:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf3b9c5368b230baf30a97e2ddfa4529fc1bb0e5
Cr-Commit-Position: refs/heads/master@{#388305}

Powered by Google App Engine
This is Rietveld 408576698