chrome/service/cloud_print/cloud_print_url_fetcher.cc - Issue 1899083002: Convert //chrome from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/service/cloud_print/cloud_print_url_fetcher.cc

Issue 1899083002: Convert //chrome from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/service/cloud_print/cloud_print_url_fetcher.h ('k') | chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/service/cloud_print/cloud_print_url_fetcher.cc

diff --git a/chrome/service/cloud_print/cloud_print_url_fetcher.cc b/chrome/service/cloud_print/cloud_print_url_fetcher.cc

index ef937359f774999ce9dbb2c97bcc3b6ea121cb65..9ccf523e140e122806624125a2a7344294d054ce 100644

--- a/chrome/service/cloud_print/cloud_print_url_fetcher.cc

+++ b/chrome/service/cloud_print/cloud_print_url_fetcher.cc

@@ -202,7 +202,7 @@ void CloudPrintURLFetcher::OnURLFetchComplete(

// response, we will retry (to handle the case where we got redirected

// to a non-cloudprint-server URL eg. for authentication).

bool succeeded = false;

- scoped_ptr<base::DictionaryValue> response_dict =

+ std::unique_ptr<base::DictionaryValue> response_dict =

ParseResponseJSON(data, &succeeded);

if (response_dict) {