chrome/app_shim/chrome_main_app_mode_mac.mm - Issue 1899083002: Convert //chrome from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app_shim/chrome_main_app_mode_mac.mm

Issue 1899083002: Convert //chrome from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/app_shim/chrome_main_app_mode_mac.mm

diff --git a/chrome/app_shim/chrome_main_app_mode_mac.mm b/chrome/app_shim/chrome_main_app_mode_mac.mm

index 72e751bede9bcd03b775c4b0ff8b6290d9b355b2..af4b62a0db5f066c584fc0b7c2b5d4186eb10ce8 100644

--- a/chrome/app_shim/chrome_main_app_mode_mac.mm

+++ b/chrome/app_shim/chrome_main_app_mode_mac.mm

@@ -141,7 +141,7 @@ class AppShimController : public IPC::Listener {

void Close();

base::FilePath user_data_dir_;

- scoped_ptr<IPC::ChannelProxy> channel_;

+ std::unique_ptr<IPC::ChannelProxy> channel_;

base::scoped_nsobject<AppShimDelegate> delegate_;

bool launch_app_done_;

bool ping_chrome_reply_received_;

« no previous file with comments | « chrome/app/mash/mash_runner.cc ('k') | chrome/browser/browsing_data/cookies_tree_model.h » ('j') | no next file with comments »