chrome/app/chrome_watcher_command_line_win.cc - Issue 1899083002: Convert //chrome from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/chrome_watcher_command_line_win.cc

Issue 1899083002: Convert //chrome from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/app/chrome_watcher_command_line_win.h ('k') | chrome/app/chrome_watcher_command_line_win_unittest.cc » ('j') | chrome/installer/mini_installer/decompress.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/app/chrome_watcher_command_line_win.cc

diff --git a/chrome/app/chrome_watcher_command_line_win.cc b/chrome/app/chrome_watcher_command_line_win.cc

index 2f79dbc700dec19f60e8bcfa95682a2224c2c190..6858de6efaafcb85b7482eee1bac6214f9819879 100644

--- a/chrome/app/chrome_watcher_command_line_win.cc

+++ b/chrome/app/chrome_watcher_command_line_win.cc

@@ -114,7 +114,7 @@ ChromeWatcherCommandLine::~ChromeWatcherCommandLine() {

<< "Handles left untaken.";

}

-scoped_ptr<ChromeWatcherCommandLine>

+std::unique_ptr<ChromeWatcherCommandLine>

ChromeWatcherCommandLine::InterpretCommandLine(

const base::CommandLine& command_line) {

base::win::ScopedHandle on_initialized_event_handle;

@@ -126,9 +126,9 @@ ChromeWatcherCommandLine::InterpretCommandLine(

if (!InterpretChromeWatcherCommandLine(

command_line, &parent_process_handle, &main_thread_id,

&on_initialized_event_handle))

- return scoped_ptr<ChromeWatcherCommandLine>();

+ return std::unique_ptr<ChromeWatcherCommandLine>();

- return scoped_ptr<ChromeWatcherCommandLine>(new ChromeWatcherCommandLine(

+ return std::unique_ptr<ChromeWatcherCommandLine>(new ChromeWatcherCommandLine(

on_initialized_event_handle.Take(), parent_process_handle.Take(),

main_thread_id));

}