Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 189903002: Rename allowCookies to allowStoredCredentials (Closed)

Created:
6 years, 9 months ago by Hajime Morrita
Modified:
6 years, 9 months ago
CC:
blink-reviews, dglazkov+blink, Nate Chapin, gavinp+loader_chromium.org, adamk+blink_chromium.org
Visibility:
Public.

Description

Rename allowCookies to allowStoredCredentials And remove an redundant flag from WebURLRequest. These two represent the same thing thus should be merged. TEST=none BUG=none R=japhet@chromium.org, abarth@chromium.org, darin@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168867

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -34 lines) Patch
M Source/core/fetch/CrossOriginAccessControl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/fetch/RawResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/Resource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLPreloadScanner.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/exported/WebURLRequest.cpp View 2 chunks +2 lines, -13 lines 0 comments Download
M Source/platform/exported/WebURLRequestPrivate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/network/ResourceRequest.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/network/ResourceRequest.cpp View 5 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Hajime Morrita
PTAL? This is a cleanup. I need this before landing my imports change. Note that ...
6 years, 9 months ago (2014-03-07 03:13:38 UTC) #1
abarth-chromium
lgtm
6 years, 9 months ago (2014-03-07 05:55:12 UTC) #2
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 9 months ago (2014-03-10 19:50:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/189903002/1
6 years, 9 months ago (2014-03-10 19:50:28 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-10 20:35:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel
6 years, 9 months ago (2014-03-10 20:35:20 UTC) #6
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 9 months ago (2014-03-10 21:21:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/189903002/1
6 years, 9 months ago (2014-03-10 21:22:01 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-10 22:17:10 UTC) #9
Message was sent while issue was closed.
Change committed as 168867

Powered by Google App Engine
This is Rietveld 408576698