Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 1898993002: Allow pdfium_test to send simple events to each page. (Closed)

Created:
4 years, 8 months ago by Tom Sepez
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Allow pdfium_test to send simple events to each page. We add the --send-events flag, which causes pdfium_test to look for a .evt file with the same base name as the .pdf file being rendered, and to use its contents to drive calls to FORM_* APIs. The .evt file syntax is crude, roughly: # comments keycode,65 mousedown,right,300,300 # more comments mouseup,right,300,300 mousemove,300,300 Committed: https://pdfium.googlesource.com/pdfium/+/f09bdfa90d6324813309e987a07b28c1b75aec72

Patch Set 1 #

Total comments: 3

Patch Set 2 : Some APIs not present unless XFA #

Patch Set 3 : Fix build, nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -7 lines) Patch
M samples/pdfium_test.cc View 1 2 7 chunks +97 lines, -7 lines 0 comments Download
M testing/test_support.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M testing/test_support.cpp View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Tom Sepez
Lei, for review.
4 years, 8 months ago (2016-04-18 21:57:19 UTC) #4
Lei Zhang
lgtm https://codereview.chromium.org/1898993002/diff/1/samples/pdfium_test.cc File samples/pdfium_test.cc (right): https://codereview.chromium.org/1898993002/diff/1/samples/pdfium_test.cc#newcode477 samples/pdfium_test.cc:477: fprintf(stderr, "Unrecognined event: %s\n", tokens[0].c_str()); typo https://codereview.chromium.org/1898993002/diff/1/samples/pdfium_test.cc#newcode828 samples/pdfium_test.cc:828: ...
4 years, 8 months ago (2016-04-18 22:49:10 UTC) #6
Tom Sepez
https://codereview.chromium.org/1898993002/diff/1/samples/pdfium_test.cc File samples/pdfium_test.cc (right): https://codereview.chromium.org/1898993002/diff/1/samples/pdfium_test.cc#newcode477 samples/pdfium_test.cc:477: fprintf(stderr, "Unrecognined event: %s\n", tokens[0].c_str()); On 2016/04/18 22:49:10, Lei ...
4 years, 8 months ago (2016-04-18 23:02:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898993002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898993002/40001
4 years, 8 months ago (2016-04-18 23:08:08 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 23:08:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/f09bdfa90d6324813309e987a07b28c1b75a...

Powered by Google App Engine
This is Rietveld 408576698