pkg/analysis_server/lib/src/services/completion/dart/type_member_contributor.dart - Issue 1898983004: Code completion API refactoring: replace resolveExpression(Expression) with resolveContainingExpres…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/type_member_contributor.dart

Issue 1898983004: Code completion API refactoring: replace resolveExpression(Expression) with resolveContainingExpres… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Comments from danrubel Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analysis_server/lib/src/services/completion/dart/type_member_contributor.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart/type_member_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/type_member_contributor.dart

index 9dbc7e20fcb83cc09fdca0541205230f53278e0a..0cf93185d9de6a66d3f6ed5f751a3befd8125e7a 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart/type_member_contributor.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart/type_member_contributor.dart

@@ -32,7 +32,7 @@ class TypeMemberContributor extends DartCompletionContributor {

}

// Resolve the expression and the containing library

- await request.resolveExpression(parsedExpression);

+ await request.resolveContainingExpression(parsedExpression);

LibraryElement containingLibrary = request.libraryElement;

// Gracefully degrade if the library element could not be resolved

// e.g. detached part file or source change

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/static_member_contributor.dart ('k') | no next file » | no next file with comments »