pkg/analysis_server/lib/src/services/completion/dart/imported_reference_contributor.dart - Issue 1898983004: Code completion API refactoring: replace resolveExpression(Expression) with resolveContainingExpres…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/imported_reference_contributor.dart

Issue 1898983004: Code completion API refactoring: replace resolveExpression(Expression) with resolveContainingExpres… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Comments from danrubel Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart ('k') | pkg/analysis_server/lib/src/services/completion/dart/library_member_contributor.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/dart/imported_reference_contributor.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart/imported_reference_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/imported_reference_contributor.dart

index f169ccfab6ef719f586fe46fccd0c8674f2f978f..89dd436d8a273de5b31f4eba51a8b1f4e0506aad 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart/imported_reference_contributor.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart/imported_reference_contributor.dart

@@ -57,10 +57,7 @@ class ImportedReferenceContributor extends DartCompletionContributor {

// then resolve the outermost/entire expression

AstNode node = request.target.containingNode;

if (node is Expression) {

- while (node.parent is Expression) {

- node = node.parent;

- }

- await request.resolveExpression(node);

+ await request.resolveContainingExpression(node);

// Discard any cached target information

// because it may have changed as a result of the resolution