Stop overriding the image capability to true in BlimpContextProvider.

Stop overriding the image capability to true in BlimpContextProvider.

It should be true if the GL context supports it, and off otherwise.
Lying isn't helpful.

It was added in the initial blimp/ commit, without discussion about
why it was there, though it was at least considered as it came up
here: https://chromiumcodereview.appspot.com/1295243003/diff/20001/blimp/client/compositor/blimp_context_provider.cc?_ga=1.66997032.780449993.1417466767#newcode101

R=dtrainor@chromium.org
BUG=584497
Committed: https://crrev.com/0ce11d5543e93e65fbf9a61d92e37f6830734357
Cr-Commit-Position: refs/heads/master@{#388580}

[danakj, 2016-04-19 21:39:10]

See comment here:
https://codereview.chromium.org/1900993002/diff/90001/blimp/client/feature/co...

[danakj, 2016-04-19 21:43:28]

This is the GpuMemoryManager that gets passed to the BlimpContextProvider,
making it not-null.
https://code.google.com/p/chromium/codesearch#chromium/src/blimp/client/featu...

This is where the capability is defaulted to true as long as the GMM is not
null:
https://code.google.com/p/chromium/codesearch#chromium/src/gpu/command_buffer...

[danakj, 2016-04-19 21:43:53]

danakj@chromium.org changed reviewers:
+ wez@chromium.org

[danakj, 2016-04-19 21:43:54]

+wez if david is still OOO

[Wez, 2016-04-19 21:57:26]

wez@chromium.org changed reviewers:
+ nyquist@chromium.org
- dtrainor@chromium.org

[Wez, 2016-04-19 21:57:26]

Tommy, can you confirm that this is not required, or provide a suitable comment
to explain why it is?

kthxbai

[nyquist, 2016-04-20 00:16:24]

This is not required anymore, since Khushal added the GPUMemoryBufferManager.
Before that, we needed to explicitly set it.

So thanks for cleaning this up!

lgtm

[danakj, 2016-04-20 00:20:47]

Thanks, I rebased this on top of  https://codereview.chromium.org/1900993002/#

[danakj, 2016-04-20 02:21:00]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 02:21:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1898983003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1898983003/40001

[commit-bot: I haz the power, 2016-04-20 03:19:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 03:19:22]

Dry run: This issue passed the CQ dry run.

[danakj, 2016-04-20 21:17:22]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-04-20 21:17:22]

The patchset sent to the CQ was uploaded after l-g-t-m from nyquist@chromium.org
Link to the patchset: https://codereview.chromium.org/1898983003/#ps40001
(title: "blimpimage: rebase")

[commit-bot: I haz the power, 2016-04-20 21:17:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1898983003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1898983003/40001

[commit-bot: I haz the power, 2016-04-20 21:30:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-22 19:26:36]

Description was changed from

==========
Stop overriding the image capability to true in BlimpContextProvider.

It should be true if the GL context supports it, and off otherwise.
Lying isn't helpful.

It was added in the initial blimp/ commit, without discussion about
why it was there, though it was at least considered as it came up
here:
https://chromiumcodereview.appspot.com/1295243003/diff/20001/blimp/client/com...

R=dtrainor@chromium.org
BUG=584497
==========

to

==========
Stop overriding the image capability to true in BlimpContextProvider.

It should be true if the GL context supports it, and off otherwise.
Lying isn't helpful.

It was added in the initial blimp/ commit, without discussion about
why it was there, though it was at least considered as it came up
here:
https://chromiumcodereview.appspot.com/1295243003/diff/20001/blimp/client/com...

R=dtrainor@chromium.org
BUG=584497

Committed: https://crrev.com/0ce11d5543e93e65fbf9a61d92e37f6830734357
Cr-Commit-Position: refs/heads/master@{#388580}
==========

[commit-bot: I haz the power, 2016-04-22 19:26:37]

Patchset 3 (id:??) landed as
https://crrev.com/0ce11d5543e93e65fbf9a61d92e37f6830734357
Cr-Commit-Position: refs/heads/master@{#388580}