Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1898983002: Update ChromeOS Build Instructions for GN (Closed)

Created:
4 years, 8 months ago by stevenjb
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke, hashimoto
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update ChromeOS Build Instructions for GN BUG=none Committed: https://crrev.com/ec7b4e3c382e57eefa828b99ba43568bd151e5ea Cr-Commit-Position: refs/heads/master@{#388060}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -51 lines) Patch
M docs/chromeos_build_instructions.md View 1 2 3 chunks +29 lines, -51 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
stevenjb
4 years, 8 months ago (2016-04-18 21:45:53 UTC) #2
Dirk Pranke
lgtm https://codereview.chromium.org/1898983002/diff/20001/docs/chromeos_build_instructions.md File docs/chromeos_build_instructions.md (right): https://codereview.chromium.org/1898983002/diff/20001/docs/chromeos_build_instructions.md#newcode49 docs/chromeos_build_instructions.md:49: When target_os=chromeos, then toolkit\_views should not be specified. ...
4 years, 8 months ago (2016-04-18 21:49:30 UTC) #3
stevenjb
https://codereview.chromium.org/1898983002/diff/20001/docs/chromeos_build_instructions.md File docs/chromeos_build_instructions.md (right): https://codereview.chromium.org/1898983002/diff/20001/docs/chromeos_build_instructions.md#newcode49 docs/chromeos_build_instructions.md:49: When target_os=chromeos, then toolkit\_views should not be specified. On ...
4 years, 8 months ago (2016-04-18 22:01:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898983002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898983002/40001
4 years, 8 months ago (2016-04-18 22:02:53 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-18 22:52:16 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 22:54:01 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ec7b4e3c382e57eefa828b99ba43568bd151e5ea
Cr-Commit-Position: refs/heads/master@{#388060}

Powered by Google App Engine
This is Rietveld 408576698