Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 1898953003: Record that the window is mapped when we receive a MapNotify event. (Closed)

Created:
4 years, 8 months ago by Elliot Glaysher
Modified:
4 years, 8 months ago
Reviewers:
danakj, Tom Anderson
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Record that the window is mapped when we receive a MapNotify event. Previously, we recorded that we mapped a window after we waited for a MapNotify event after we called XMapWindow(). While this should theoretically never happen, we appear to be getting MapNotify events when we haven't called XMapWindow(). Record that the window is mapped whenever we get a MapNotify instead so that we at least don't block waiting for a MapNotify that will never come. BUG=381732 Committed: https://crrev.com/2c9261719c810fd986b2bb3b1e1206de7e4094f3 Cr-Commit-Position: refs/heads/master@{#388040}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 2 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Elliot Glaysher
4 years, 8 months ago (2016-04-18 20:57:30 UTC) #2
danakj
Oh yes. Doing things in the event handler is the right way anyways, so LGTM!
4 years, 8 months ago (2016-04-18 21:04:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898953003/1
4 years, 8 months ago (2016-04-18 21:59:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 22:16:22 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 22:18:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c9261719c810fd986b2bb3b1e1206de7e4094f3
Cr-Commit-Position: refs/heads/master@{#388040}

Powered by Google App Engine
This is Rietveld 408576698