Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Issue 1898923002: Merge to 2704 "[DevTools] Introduce a setting for console autocomplete from history." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/console/module.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
index 302287817a3a255d9172548ca4461eff65c2cfcf..12985579d09d7211e6b0f3e5e97e5b058ed9e078 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
@@ -141,6 +141,10 @@ WebInspector.ConsoleView = function()
var historyData = this._consoleHistorySetting.get();
this._prompt.setHistoryData(historyData);
+ this._consoleHistoryAutocompleteSetting = WebInspector.moduleSetting("consoleHistoryAutocomplete");
+ this._consoleHistoryAutocompleteSetting.addChangeListener(this._consoleHistoryAutocompleteChanged, this);
+ this._consoleHistoryAutocompleteChanged();
+
this._updateFilterStatus();
WebInspector.moduleSetting("consoleTimestampsEnabled").addChangeListener(this._consoleTimestampsSettingChanged, this);
@@ -170,6 +174,11 @@ WebInspector.ConsoleView.prototype = {
this._prompt.setHistoryData([]);
},
+ _consoleHistoryAutocompleteChanged: function()
+ {
+ this._prompt.setAddCompletionsFromHistory(this._consoleHistoryAutocompleteSetting.get());
+ },
+
/**
* @param {!WebInspector.Event} event
*/
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/console/module.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698