tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 3350b3a028b5037d7f9e254d8b2a9316331337c4..cafee78c5370a7235af08e38e26ee3d51fb841b9 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -10109,6 +10109,43 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="DNS.StaleHostResolver.NetworkEarly" units="ms">
+  <owner>juliatuttle@chromium.org</owner>
+  <summary>
+    When a DNS request made through StaleHostResolver returns, a stale cached
+    result was available, and the network responded before or exactly at the
+    stale delay, how much earlier it responded.
+  </summary>
+</histogram>
+
+<histogram name="DNS.StaleHostResolver.NetworkLate" units="ms">
+  <owner>juliatuttle@chromium.org</owner>
+  <summary>
+    When a DNS request made through StaleHostResolver returns, a stale cached
+    result was available, and the network responded after the stale delay, how
+    much later it responded.
+  </summary>
+</histogram>
+
+<histogram name="DNS.StaleHostResolver.RequestOutcome"
+    enum="DNS.StaleHostResolverRequestOutcome">
+  <owner>juliatuttle@chromium.org</owner>
+  <summary>
+    When a DNS request made through StaleHostResolver returns or is canceled,
+    the outcome of the request.
+  </summary>
+</histogram>
+
+<histogram name="DNS.StaleHostResolver.StaleAddressListDelta"
+    enum="DNS.AddressListDeltaType">
+  <owner>juliatuttle@chromium.org</owner>
+  <summary>
+    When a DNS request made through StaleHostResolver had a stale cached result
+    and both the stale and network results were successful, the difference

[Mark P, 2016/08/16 17:59:03]

That's fine here.  I was suggesting that you revise
DNS.StaleHostResolver.NetworkEarly and DNS.StaleHostResolver.NetworkLate from
"and the network responded {before,after}" to "and the network responded
successfully {before,after}", if indeed you only record those histograms on
successful network responses, not errors.

As for the histogram DNS.StaleHostResolver.RequestOutcome, I assume that you
record this regardless of whether the network response succeeded; please correct
me if I'm wrong.

(This is what I meant  by the "above histograms", i.e., not this histogram; this
histogram is fine.)

+    between the old and new address lists.
+  </summary>
+</histogram>
+
 <histogram name="DNS.TotalTime" units="ms">
   <owner>juliatuttle@chromium.org</owner>
   <summary>
@@ -73142,6 +73179,18 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   <int value="2" label="Updated stale entry"/>
 </enum>
 
+<enum name="DNS.StaleHostResolverRequestOutcome" type="int">
+  <int value="0"
+      label="Returned synchronously (cache, hosts, IP literal etc.)"/>
+  <int value="1"
+      label="Returned network result; no stale cached result was available."/>
+  <int value="2"
+      label="Returned network result; stale cached result was available."/>
+  <int value="3" label="Returned stale cached result; network was too slow."/>
+  <int value="4" label="Canceled; no stale cached result was available."/>
+  <int value="5" label="Canceled; stale cached result was available."/>
+</enum>
+
 <enum name="DNSEmptyAddressListAndNoError" type="int">
   <int value="0" label="Error reported or Address List is not empty"/>
   <int value="1" label="Success reported but Address List is empty"/>