Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: components/cronet/stale_host_resolver.h

Issue 1898873006: Cronet: Use stale DNS cache entries experimentally. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dns_stale2
Patch Set: rebase, make requested changes Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef COMPONENTS_CRONET_STALE_HOST_RESOLVER_H_
6 #define COMPONENTS_CRONET_STALE_HOST_RESOLVER_H_
7
8 #include <set>
9
10 #include "net/dns/host_resolver.h"
11 #include "net/dns/host_resolver_impl.h"
12
13 namespace cronet {
14
15 // A HostResolver that wraps a HostResolverImpl and uses it to make requests,
16 // but "impatiently" returns stale data (if available and usable) after a delay,
17 // to reduce DNS latency at the expense of accuracy.
18 class NET_EXPORT StaleHostResolver : public net::HostResolver {
19 public:
20 struct NET_EXPORT StaleOptions {
21 // How long to wait before returning stale data, if available.
22 base::TimeDelta delay;
23
24 // If positive, how long stale data can be past the expiration time before
25 // it's considered unusable. If zero or negative, stale data can be used
26 // indefinitely.
27 base::TimeDelta max_expired_time;
28
29 // If set, stale data from previous networks is usable; if clear, it's not.
30 //
31 // If the other network had a working, correct DNS setup, this can increase
32 // the availability of useful stale results.
33 //
34 // If the other network had a broken (e.g. hijacked for captive portal) DNS
35 // setup, this will instead end up returning useless results.
36 bool allow_other_network;
37
38 // If positive, the maximum number of times a stale entry can be used. If
39 // zero, there is no limit.
40 int max_stale_uses;
41 };
42
43 // Creates a StaleHostResolver that uses |inner_resolver| for actual
44 // resolution, but potentially returns stale data according to
45 // |stale_options|.
46 StaleHostResolver(std::unique_ptr<net::HostResolverImpl> inner_resolver,
47 const StaleOptions& stale_options);
48
49 // Cancels all pending calls to Resolve, and does not call their callbacks.
50 ~StaleHostResolver() override;
51
52 // HostResolver implementation:
53
54 // Resolves as a regular HostResolver, but if stale data is available and
55 // usable (according to the options passed to the constructor), and fresh data
56 // is not returned before the specified delay, returns the stale data instead.
57 //
58 // If stale data is returned, the StaleHostResolver allows the underlying
59 // request to continue in order to repopulate the cache.
60 int Resolve(const RequestInfo& info,
61 net::RequestPriority priority,
62 net::AddressList* addresses,
63 const net::CompletionCallback& callback,
64 RequestHandle* out_req,
65 const net::BoundNetLog& net_log) override;
66
67 void CancelRequest(RequestHandle req) override;
68
69 // The remaining public methods pass through to the inner resolver:
70
71 int ResolveFromCache(const RequestInfo& info,
72 net::AddressList* addresses,
73 const net::BoundNetLog& net_log) override;
74 void SetDnsClientEnabled(bool enabled) override;
75 net::HostCache* GetHostCache() override;
76 std::unique_ptr<base::Value> GetDnsConfigAsValue() const override;
77
78 private:
79 class Request;
80
81 void OnRequestComplete(Request* request,
xunjieli 2016/06/13 19:25:04 Need documentation.
Julia Tuttle 2016/06/14 23:11:32 Done.
82 const net::CompletionCallback& outer_callback,
83 int error);
84
85 std::unique_ptr<net::HostResolverImpl> resolver_;
86 StaleOptions options_;
87 std::set<Request*> pending_requests_;
xunjieli 2016/06/13 19:25:04 need documentation.
Julia Tuttle 2016/06/14 23:11:32 Done.
88 };
89
90 } // namespace cronet
91
92 #endif // COMPONENTS_CRONET_STALE_HOST_RESOLVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698