src/utils/debugger/SkDebugCanvas.cpp - Issue 189883010: hide getTotalClip, so we can eventually remove it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/utils/debugger/SkDebugCanvas.cpp

Issue 189883010: hide getTotalClip, so we can eventually remove it (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/utils/debugger/SkDebugCanvas.cpp

diff --git a/src/utils/debugger/SkDebugCanvas.cpp b/src/utils/debugger/SkDebugCanvas.cpp

index 066d7a601ab662765d201759ecd47d2c8b14cee3..08e6d94f9e58eb717f363b9a50e70ffd624bc6f9 100644

--- a/src/utils/debugger/SkDebugCanvas.cpp

+++ b/src/utils/debugger/SkDebugCanvas.cpp

@@ -328,7 +328,9 @@ void SkDebugCanvas::drawTo(SkCanvas* canvas, int index) {

canvas->restore();

}

fMatrix = canvas->getTotalMatrix();

- fClip = canvas->getTotalClip().getBounds();

+ if (!canvas->getClipDeviceBounds(&fClip)) {

+ fClip.setEmpty();

+ }

fIndex = index;

}

« no previous file with comments | « src/utils/debugger/SkDebugCanvas.h ('k') | tests/CanvasTest.cpp » ('j') | no next file with comments »