src/a64/code-stubs-a64.cc - Issue 189883006: A64: Tidy up a couple of TODOs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/a64/code-stubs-a64.cc

Issue 189883006: A64: Tidy up a couple of TODOs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/a64/code-stubs-a64.cc

diff --git a/src/a64/code-stubs-a64.cc b/src/a64/code-stubs-a64.cc

index a3aad78f75fc0ba05d67febeb19f69905b43c75c..fad3e589d3f65b2c1637819e6129c1b14e1ad08a 100644

--- a/src/a64/code-stubs-a64.cc

+++ b/src/a64/code-stubs-a64.cc

@@ -4937,8 +4937,7 @@ void StoreArrayLiteralElementStub::Generate(MacroAssembler* masm) {

void StubFailureTrampolineStub::Generate(MacroAssembler* masm) {

- // TODO(jbramley): The ARM code leaves the (shifted) offset in r1. Why?

- CEntryStub ces(1, kSaveFPRegs);

+ CEntryStub ces(1, fp_registers_ ? kSaveFPRegs : kDontSaveFPRegs);

__ Call(ces.GetCode(masm->isolate()), RelocInfo::CODE_TARGET);

int parameter_count_offset =

StubFailureTrampolineFrame::kCallerStackParameterCountFrameOffset;

« no previous file with comments | « no previous file | src/a64/ic-a64.cc » ('j') | no next file with comments »