Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: src/a64/macro-assembler-a64.cc

Issue 189883006: A64: Tidy up a couple of TODOs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/a64/ic-a64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1479 matching lines...) Expand 10 before | Expand all | Expand 10 after
1490 if (emit_debug_code()) { 1490 if (emit_debug_code()) {
1491 STATIC_ASSERT(kSmiTag == 0); 1491 STATIC_ASSERT(kSmiTag == 0);
1492 Tst(object, kSmiTagMask); 1492 Tst(object, kSmiTagMask);
1493 Check(ne, reason); 1493 Check(ne, reason);
1494 } 1494 }
1495 } 1495 }
1496 1496
1497 1497
1498 void MacroAssembler::AssertName(Register object) { 1498 void MacroAssembler::AssertName(Register object) {
1499 if (emit_debug_code()) { 1499 if (emit_debug_code()) {
1500 STATIC_ASSERT(kSmiTag == 0); 1500 AssertNotSmi(object, kOperandIsASmiAndNotAName);
1501 // TODO(jbramley): Add AbortIfSmi and related functions.
1502 Label not_smi;
1503 JumpIfNotSmi(object, &not_smi);
1504 Abort(kOperandIsASmiAndNotAName);
1505 Bind(&not_smi);
1506 1501
1507 Ldr(Tmp1(), FieldMemOperand(object, HeapObject::kMapOffset)); 1502 Ldr(Tmp1(), FieldMemOperand(object, HeapObject::kMapOffset));
1508 CompareInstanceType(Tmp1(), Tmp1(), LAST_NAME_TYPE); 1503 CompareInstanceType(Tmp1(), Tmp1(), LAST_NAME_TYPE);
1509 Check(ls, kOperandIsNotAName); 1504 Check(ls, kOperandIsNotAName);
1510 } 1505 }
1511 } 1506 }
1512 1507
1513 1508
1514 void MacroAssembler::AssertString(Register object) { 1509 void MacroAssembler::AssertString(Register object) {
1515 if (emit_debug_code()) { 1510 if (emit_debug_code()) {
(...skipping 1285 matching lines...) Expand 10 before | Expand all | Expand 10 after
2801 2796
2802 // TODO(rmcilroy): Remove this Sxtw once the following bug is fixed: 2797 // TODO(rmcilroy): Remove this Sxtw once the following bug is fixed:
2803 // https://code.google.com/p/v8/issues/detail?id=3149 2798 // https://code.google.com/p/v8/issues/detail?id=3149
2804 Sxtw(result, result.W()); 2799 Sxtw(result, result.W());
2805 } 2800 }
2806 2801
2807 2802
2808 void MacroAssembler::Prologue(PrologueFrameMode frame_mode) { 2803 void MacroAssembler::Prologue(PrologueFrameMode frame_mode) {
2809 if (frame_mode == BUILD_STUB_FRAME) { 2804 if (frame_mode == BUILD_STUB_FRAME) {
2810 ASSERT(StackPointer().Is(jssp)); 2805 ASSERT(StackPointer().Is(jssp));
2811 // TODO(jbramley): Does x1 contain a JSFunction here, or does it already
2812 // have the special STUB smi?
2813 __ Mov(Tmp0(), Operand(Smi::FromInt(StackFrame::STUB))); 2806 __ Mov(Tmp0(), Operand(Smi::FromInt(StackFrame::STUB)));
2814 // Compiled stubs don't age, and so they don't need the predictable code 2807 // Compiled stubs don't age, and so they don't need the predictable code
2815 // ageing sequence. 2808 // ageing sequence.
2816 __ Push(lr, fp, cp, Tmp0()); 2809 __ Push(lr, fp, cp, Tmp0());
2817 __ Add(fp, jssp, StandardFrameConstants::kFixedFrameSizeFromFp); 2810 __ Add(fp, jssp, StandardFrameConstants::kFixedFrameSizeFromFp);
2818 } else { 2811 } else {
2819 if (isolate()->IsCodePreAgingActive()) { 2812 if (isolate()->IsCodePreAgingActive()) {
2820 Code* stub = Code::GetPreAgedCodeAgeStub(isolate()); 2813 Code* stub = Code::GetPreAgedCodeAgeStub(isolate());
2821 __ EmitCodeAgeSequence(stub); 2814 __ EmitCodeAgeSequence(stub);
2822 } else { 2815 } else {
(...skipping 2154 matching lines...) Expand 10 before | Expand all | Expand 10 after
4977 } 4970 }
4978 } 4971 }
4979 4972
4980 4973
4981 #undef __ 4974 #undef __
4982 4975
4983 4976
4984 } } // namespace v8::internal 4977 } } // namespace v8::internal
4985 4978
4986 #endif // V8_TARGET_ARCH_A64 4979 #endif // V8_TARGET_ARCH_A64
OLDNEW
« no previous file with comments | « src/a64/ic-a64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698