Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/a64/code-stubs-a64.cc

Issue 189883006: A64: Tidy up a couple of TODOs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/a64/ic-a64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4919 matching lines...) Expand 10 before | Expand all | Expand 10 after
4930 4930
4931 __ Bind(&double_elements); 4931 __ Bind(&double_elements);
4932 __ Ldr(x10, FieldMemOperand(array, JSObject::kElementsOffset)); 4932 __ Ldr(x10, FieldMemOperand(array, JSObject::kElementsOffset));
4933 __ StoreNumberToDoubleElements(value, index_smi, x10, x11, d0, d1, 4933 __ StoreNumberToDoubleElements(value, index_smi, x10, x11, d0, d1,
4934 &slow_elements); 4934 &slow_elements);
4935 __ Ret(); 4935 __ Ret();
4936 } 4936 }
4937 4937
4938 4938
4939 void StubFailureTrampolineStub::Generate(MacroAssembler* masm) { 4939 void StubFailureTrampolineStub::Generate(MacroAssembler* masm) {
4940 // TODO(jbramley): The ARM code leaves the (shifted) offset in r1. Why? 4940 CEntryStub ces(1, fp_registers_ ? kSaveFPRegs : kDontSaveFPRegs);
4941 CEntryStub ces(1, kSaveFPRegs);
4942 __ Call(ces.GetCode(masm->isolate()), RelocInfo::CODE_TARGET); 4941 __ Call(ces.GetCode(masm->isolate()), RelocInfo::CODE_TARGET);
4943 int parameter_count_offset = 4942 int parameter_count_offset =
4944 StubFailureTrampolineFrame::kCallerStackParameterCountFrameOffset; 4943 StubFailureTrampolineFrame::kCallerStackParameterCountFrameOffset;
4945 __ Ldr(x1, MemOperand(fp, parameter_count_offset)); 4944 __ Ldr(x1, MemOperand(fp, parameter_count_offset));
4946 if (function_mode_ == JS_FUNCTION_STUB_MODE) { 4945 if (function_mode_ == JS_FUNCTION_STUB_MODE) {
4947 __ Add(x1, x1, 1); 4946 __ Add(x1, x1, 1);
4948 } 4947 }
4949 masm->LeaveFrame(StackFrame::STUB_FAILURE_TRAMPOLINE); 4948 masm->LeaveFrame(StackFrame::STUB_FAILURE_TRAMPOLINE);
4950 __ Drop(x1); 4949 __ Drop(x1);
4951 // Return to IC Miss stub, continuation still on stack. 4950 // Return to IC Miss stub, continuation still on stack.
(...skipping 857 matching lines...) Expand 10 before | Expand all | Expand 10 after
5809 MemOperand(fp, 6 * kPointerSize), 5808 MemOperand(fp, 6 * kPointerSize),
5810 NULL); 5809 NULL);
5811 } 5810 }
5812 5811
5813 5812
5814 #undef __ 5813 #undef __
5815 5814
5816 } } // namespace v8::internal 5815 } } // namespace v8::internal
5817 5816
5818 #endif // V8_TARGET_ARCH_A64 5817 #endif // V8_TARGET_ARCH_A64
OLDNEW
« no previous file with comments | « no previous file | src/a64/ic-a64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698